From owner-p4-projects@FreeBSD.ORG  Thu Dec 18 12:35:51 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 39D371065675; Thu, 18 Dec 2008 12:35:51 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F1AD11065674
	for <perforce@FreeBSD.org>; Thu, 18 Dec 2008 12:35:50 +0000 (UTC)
	(envelope-from weongyo@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id E116A8FC08
	for <perforce@FreeBSD.org>; Thu, 18 Dec 2008 12:35:50 +0000 (UTC)
	(envelope-from weongyo@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mBICZoSp036407
	for <perforce@FreeBSD.org>; Thu, 18 Dec 2008 12:35:50 GMT
	(envelope-from weongyo@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mBICZobT036405
	for perforce@freebsd.org; Thu, 18 Dec 2008 12:35:50 GMT
	(envelope-from weongyo@FreeBSD.org)
Date: Thu, 18 Dec 2008 12:35:50 GMT
Message-Id: <200812181235.mBICZobT036405@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	weongyo@FreeBSD.org using -f
From: Weongyo Jeong <weongyo@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 154931 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2008 12:35:51 -0000

http://perforce.freebsd.org/chv.cgi?CH=154931

Change 154931 by weongyo@weongyo_ws on 2008/12/18 12:34:53

	IMO if the USB framework returns USBD_CANCELLED then we also should
	set USBD_URB_STATUS(urb) as USBD_STATUS_CANCELED not
	USBD_STATUS_SUCCESS.  I've looked lots for NDIS driver; it looks most
	drivers set USBD_STATUS_CANCELED.  In ndiswrapper they try to set
	USBD_STATUS_SUCCESS but it looks it's incorrect.

Affected files ...

.. //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#27 edit

Differences ...

==== //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#27 (text+ko) ====

@@ -1051,7 +1051,7 @@
 		case USBD_CANCELLED:
 			ip->irp_iostat.isb_info = 0;
 			ip->irp_iostat.isb_status = STATUS_CANCELLED;
-			USBD_URB_STATUS(urb) = USBD_STATUS_SUCCESS;
+			USBD_URB_STATUS(urb) = USBD_STATUS_CANCELED;
 			break;
 		default:
 			ip->irp_iostat.isb_info = 0;