From owner-freebsd-current@FreeBSD.ORG  Wed Oct 27 06:55:51 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C034A16A4CE; Wed, 27 Oct 2004 06:55:51 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 291B243D31; Wed, 27 Oct 2004 06:55:51 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i9R6tmxO060399;
	Wed, 27 Oct 2004 08:55:49 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: John Baldwin <jhb@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 26 Oct 2004 17:04:49 EDT."
             <200410261704.49182.jhb@FreeBSD.org> 
Date: Wed, 27 Oct 2004 08:55:48 +0200
Message-ID: <60398.1098860148@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: freebsd-current@FreeBSD.org
cc: current@FreeBSD.org
cc: Tim Dettloff <dettloff@gmail.com>
Subject: Re: Solution? Re: pxe-install on FreeBSD 5.3 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Oct 2004 06:55:51 -0000

In message <200410261704.49182.jhb@FreeBSD.org>, John Baldwin writes:
>On Thursday 21 October 2004 05:24 pm, Poul-Henning Kamp wrote:
>> In message <200410211505.27635.jhb@FreeBSD.org>, John Baldwin writes:
>> >> Doesn't the search terminate if [0] is NULL ?
>> >
>> >Perhaps there should be a small wrapper function to register a candidate
>> > root with an associated priority and that wrapper function could then
>> > manage the rootdevnames[] array and keep them sorted based on the
>> > priority?
>>
>> No, the entire thing should be rototiled.
>
>Well, the interface I'm thinking of is something like
>'rootdevice_add(const char *name, int priority)' or maybe 
>'rootdevice_add(dev_t dev, int priority)' (which won't work for NFS, so I 
>guess back to the char * version) and not having the array or linked list or 
>whatever of names visible outside vfs_mount.c (or where the root mount code 
>lives).

After looking again I think I'll change my position:  This entire thing
should be yanked out and we should rely on the loader to set the right
variables instead.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.