Date: Fri, 6 Oct 2000 10:09:14 +0200 From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de> To: Alfred Perlstein <bright@wintelcom.net> Cc: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/finger finger.c Message-ID: <20001006100914.A66672@curry.mchp.siemens.de> In-Reply-To: <20001006005910.C27736@fw.wintelcom.net>; from bright@wintelcom.net on Fri, Oct 06, 2000 at 12:59:10AM -0700 References: <ru@FreeBSD.org> <200010051715.e95HFVn34590@hak.lan.Awfulhak.org> <20001005135833.A87853@citusc17.usc.edu> <20001005142209.G27736@fw.wintelcom.net> <20001006074832.A9078@curry.mchp.siemens.de> <20001005233620.B27736@fw.wintelcom.net> <20001006090131.A61051@curry.mchp.siemens.de> <20001006005910.C27736@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 06-Oct-2000 at 00:59:10 -0700, Alfred Perlstein wrote: > * Andre Albsmeier <andre.albsmeier@mchp.siemens.de> [001006 00:01] wrote: > > On Thu, 05-Oct-2000 at 23:36:20 -0700, Alfred Perlstein wrote: > > > > > > In the form it was in the PR, ie "huge gaping security hole the > > > size of Montana" it was entirely useless. > > > > > > I should have said "useless/dangerous", not all useless patches > > > are dangerous but all dangerous patches are useless until corrected. > > > > In this case, it would have been enough to write > > > > 3) realize how (f*cking) dangerous it is > > > > :-). I read your words as if you tried to say that the whole thing > > is useless but, anyway, this has been cleared out now. > > If one had weighed the value of being able to finger files on a > remote machine versus the potential security implications of the > change i'm sure it would not have been added. I agree. As a conclusion we see again how important it is to review stuff properly as you did it with my PR as well. Thankfully, Garance A. Drosehn came up with a better version real quickly. I just was a little bit upset by the useless attribute for the PR :-) -Andre To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001006100914.A66672>