Date: Wed, 30 Jun 2010 15:47:55 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: "Jayachandran C." <c.jayachandran@gmail.com> Cc: freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD Message-ID: <AANLkTinIQjzaldNkzZV97tvd2vJMAjBEsu1f8SO4roay@mail.gmail.com> In-Reply-To: <AANLkTimgyYggdDYchEfb3yskmA0PsttjVzkOSMaWFsjH@mail.gmail.com> References: <AANLkTik8jFkB7FTIIhyjalkfv1c0yXqse57Jzz527uf_@mail.gmail.com> <897604F6-95C4-49A8-B11F-277A74C8DBAE@gmail.com> <AANLkTilfW_zOFKuIa0gJ3ahTo-vGC1VNk99a1H24uFRq@mail.gmail.com> <AANLkTil78NFxH016C7MntD8L3d4rFlCudJ0Lv22L0KCb@mail.gmail.com> <3C0AEF9B-AE0C-4459-A4E1-2C8C30C10FD6@gmail.com> <AANLkTint7Hyf79EH29OLsIfreQRd7dQMdvX9wRq4v_yG@mail.gmail.com> <C6D73C96-3640-4502-A9D7-B3597E37E80A@gmail.com> <AANLkTilQIqF4FCfgLdVcKdcsAUVjCmr89Lu0TEXUFdYN@mail.gmail.com> <25B9A19D-0A6B-4731-8FB1-A2C6722F0E9C@gmail.com> <AANLkTim_9-G6ZuA0vkpLeG4n4GVBpBlxhGBy_7eQoIM4@mail.gmail.com> <C1BD2512-8A48-4AB2-B9CA-C46DDCBE5256@gmail.com> <AANLkTimgyYggdDYchEfb3yskmA0PsttjVzkOSMaWFsjH@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 30, 2010 at 15:40, Jayachandran C. <c.jayachandran@gmail.com> wrote: > I've attached the final(final.diff) version I want to check-in, can > you please quickly test it? > > If that does not work, can you tell me if the attached alt1.diff or > alt2.diff works? The try.diff had three changes: handle case of > index>0, remove pagemask operation, restore full entryhi instead of > asid. So if the first does not work, this will help narrow down the > rest of the cases. > > Hopefully this is the last iteration :) Hi JC, I think you're right that the issue is not masking enough bits in EntryHi. I suspect the other changes are not necessary and I feel that the change to always add the entry if it doesn't exist is undesirable if it's unnecessary. When a lot of otherwise-unused mappings are changing, this has the effect of spilling the TLB which kills performance. I hope someone is willing to try just the TLBHI_ENTRY changes to make sure that fixes it. Juli.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinIQjzaldNkzZV97tvd2vJMAjBEsu1f8SO4roay>