From owner-freebsd-mips@FreeBSD.ORG Wed Jun 30 22:48:22 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 720BA106566C for ; Wed, 30 Jun 2010 22:48:22 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 269D68FC08 for ; Wed, 30 Jun 2010 22:48:21 +0000 (UTC) Received: by vws6 with SMTP id 6so547722vws.13 for ; Wed, 30 Jun 2010 15:48:15 -0700 (PDT) Received: by 10.220.88.29 with SMTP id y29mr2540588vcl.72.1277938095288; Wed, 30 Jun 2010 15:48:15 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.220.188.69 with HTTP; Wed, 30 Jun 2010 15:47:55 -0700 (PDT) In-Reply-To: References: <897604F6-95C4-49A8-B11F-277A74C8DBAE@gmail.com> <3C0AEF9B-AE0C-4459-A4E1-2C8C30C10FD6@gmail.com> <25B9A19D-0A6B-4731-8FB1-A2C6722F0E9C@gmail.com> From: Juli Mallett Date: Wed, 30 Jun 2010 15:47:55 -0700 X-Google-Sender-Auth: ruvm-pHMFkews6Trsa5O2HlWEjU Message-ID: To: "Jayachandran C." Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2010 22:48:22 -0000 On Wed, Jun 30, 2010 at 15:40, Jayachandran C. wrote: > I've attached the final(final.diff) version I want to check-in, can > you please quickly test it? > > If that does not work, can you tell me if the attached alt1.diff or > alt2.diff works? The try.diff had three changes: handle case of > index>0, remove pagemask operation, restore full entryhi instead of > asid. So if the first does not work, this will help narrow down the > rest of the cases. > > Hopefully this is the last iteration :) Hi JC, I think you're right that the issue is not masking enough bits in EntryHi. I suspect the other changes are not necessary and I feel that the change to always add the entry if it doesn't exist is undesirable if it's unnecessary. When a lot of otherwise-unused mappings are changing, this has the effect of spilling the TLB which kills performance. I hope someone is willing to try just the TLBHI_ENTRY changes to make sure that fixes it. Juli.