From owner-freebsd-ports@FreeBSD.ORG Sat Jun 16 14:27:15 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3FB14106564A; Sat, 16 Jun 2012 14:27:15 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 887718FC12; Sat, 16 Jun 2012 14:27:14 +0000 (UTC) Received: by bkvi18 with SMTP id i18so3775956bkv.13 for ; Sat, 16 Jun 2012 07:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=3WzdeaS76fPUmDjc+75CDAMv36NF2p5Brt8PThAS3QA=; b=kxv2wnANaK1MGpmc0i/s3RMzkTmhJi/7heqmhlVE30ERpSG4N5k2PzrN8/07jm6A5M dQ/m5tUb8SeKbbvFU9weDj/46UMcu0pki2qiaUoaIiXTTIMrtBuClLCyB/kVen0G8f0m svDNTMv/m9J7oenWHxFmVm60o82MOlnziLRWhKl9u5ypXMW04GAi0xzC/J80N9XAj5se pj1NNM3E0SnKm4Du50bCG2thZYSxO0bLIttzdjtNJ9s+qQlJu63L6B5IsoEeBpwscTII slQGeSpBEoyBiXhlDwljgV9aIsgKdTsFoE5rsSr44hLHbSKNcAz6bRg3EgZeIbCFJwhx cmRg== Received: by 10.205.117.3 with SMTP id fk3mr4261975bkc.136.1339856833247; Sat, 16 Jun 2012 07:27:13 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.171.138 with HTTP; Sat, 16 Jun 2012 07:26:43 -0700 (PDT) In-Reply-To: <4FDC9488.2010509@FreeBSD.org> References: <4FD8AFEC.6070605@FreeBSD.org> <4FDC9488.2010509@FreeBSD.org> From: Chris Rees Date: Sat, 16 Jun 2012 15:26:43 +0100 X-Google-Sender-Auth: JHYz-tLuuYSkiHvAhVyPCXz43wA Message-ID: To: Matthew Seaman Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-ports Subject: Re: [CFT] UNIQUENAME patches X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 14:27:15 -0000 On 16 June 2012 15:13, Matthew Seaman wrote: > On 16/06/2012 14:18, Chris Rees wrote: >> That's great-- though rather than patching colliding-only ports, can't >> we just add the category to it? >> >> .for cat in ${CATEGORIES} >> UNIQUEPREFIX?=3D ${cat} >> .endfor >> >> (copying the code from PKGCATEGORY; might be better off moving the >> PKGCATEGORY code up higher and just using that). > > Yes. =A0I thought long and hard about doing that, but I opted not to for > two reasons: > > =A0 1) Using the port name + a uniqueprefix where necessary produces what > =A0 =A0 =A0is close to the minimal change required to give every port a > =A0 =A0 =A0unique name. =A0The UNIQUENAME won't actually change for quite= a > =A0 =A0 =A0lot of ports under my scheme. > > =A0 2) As a way of future-proofing against reorganizations of the ports > =A0 =A0 =A0tree. =A0What tends to happen is that a new category is invent= ed > =A0 =A0 =A0and a number of ports are moved into it. =A0My way should avoi= d > =A0 =A0 =A0changing the UNIQUENAME in the majority of cases. > > Remember that changing the UNIQUENAME changes where the record of the > port options are stored, and either we annoy a lot of users by making > them fill in a buch of dialogues all over again, or we have to invent > some complicated mechanism copy the old options settings to the new > directory. =A0(Yes -- this sort of thing will occur with the changes as > written. =A0It can't be avoided entirely.) > > Plus I think it would be more natural and easier for maintainers and > end-users to talk about (say) "phpmyadmin" rather than > "databases-phpmyadmin." Very thoughtful, OK. You'll also need some sort of cronjob then to yell at people who duplicate UNIQUENAME then, rather like erwin's LATEST_LINK script; ports/Tools/scripts/check-latest-link. Chris