From owner-freebsd-net@FreeBSD.ORG  Wed Aug 18 18:31:20 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DFB3B16A4CF
	for <freebsd-net@freebsd.org>; Wed, 18 Aug 2004 18:31:20 +0000 (GMT)
Received: from n33.kp.t-systems-sfr.com (n33.kp.t-systems-sfr.com
	[129.247.16.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DEFAD43D1F
	for <freebsd-net@freebsd.org>; Wed, 18 Aug 2004 18:31:19 +0000 (GMT)
	(envelope-from harti@freebsd.org)
Received: from n81.sp.op.dlr.de (n81g.sp.op.dlr.de [129.247.163.1])
	i7IIV0X412950;	Wed, 18 Aug 2004 20:31:00 +0200
Received: from zeus.nt.op.dlr.de (zeus.nt.op.dlr.de [129.247.173.3])
	i7IIV0I65078;	Wed, 18 Aug 2004 20:31:00 +0200
Received: from beagle.kn.op.dlr.de (opkndnwsbsd178 [129.247.173.178])
	by zeus.nt.op.dlr.de (8.11.7+Sun/8.9.1) with ESMTP id i7IIUwe19970;
	Wed, 18 Aug 2004 20:30:59 +0200 (MET DST)
Date: Wed, 18 Aug 2004 20:30:58 +0200 (CEST)
From: Harti Brandt <harti@freebsd.org>
X-X-Sender: brandt@beagle.kn.op.dlr.de
To: John Polstra <jdp@polstra.com>
In-Reply-To: <XFMail.20040818112451.jdp@polstra.com>
Message-ID: <20040818203018.C872@beagle.kn.op.dlr.de>
References: <XFMail.20040818112451.jdp@polstra.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-net@freebsd.org
cc: Julian Elischer <julian@elischer.org>
Subject: Re: netgraph only on i386/ia64 - why ?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Harti Brandt <harti@freebsd.org>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2004 18:31:21 -0000

On Wed, 18 Aug 2004, John Polstra wrote:

JP>On 18-Aug-2004 Julian Elischer wrote:
JP>> John Polstra wrote:
JP>>> 
JP>>> There is one problem with netgraph on 64-bit platforms.  The ng_msghdr
JP>>> struct is 52 bytes / 4-byte aligned (see ng_message.h).  That means
JP>>> the message payload is not well-aligned for 64-bit platforms.  It
JP>>> would be nice to fix that (and bump NG_VERSION, of course).  Nobody
JP>>> ever guaranteed that the message payload would be aligned, but it
JP>>> makes things a lot more convenient.
JP>> 
JP>> if we do this we should do it now so that we have a consistent ABI from 5.3 on..
JP>> 
JP>> scott (et al), should we pad an extra 4 bytes in this now?
JP>> it's low/no risk, but better now than after 5.3 has been released..
JP>
JP>I'd really like to see this change happen.  Julian, would it require

Yes. Please do it.

JP>bumping just NG_VERSION, or should NG_ABI_VERSION change too?

harti