From owner-freebsd-ports-bugs@freebsd.org Fri Nov 3 08:37:06 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10C60E4C250 for ; Fri, 3 Nov 2017 08:37:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F354080A97 for ; Fri, 3 Nov 2017 08:37:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vA38b5Nr064539 for ; Fri, 3 Nov 2017 08:37:05 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 223397] [NEW PORT] audio/yoshimi Date: Fri, 03 Nov 2017 08:37:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 08:37:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223397 Tobias Kortkamp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #1 from Tobias Kortkamp --- Thanks for your submission. A short review below. +PORTNAME=3D yoshimi +PORTVERSION=3D 1.5.4.1 You have invented a version number that has no basis in reality. Why is GH_TAGNAME set to a different commit than what was tagged as 1.5.4.1 by upstream? Version 1.5.4.1 is commit efce85d and not 31291f0. You may have to follow the procedure from [1] if you need newer commits. [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile= -distfiles.html#makefile-master_sites-github-ex5 +COMMENT=3D Yoshimi A Software synth The port name shouldn't appear again in COMMENT. The pkg-descr is not very descriptive and could use some work too. It sounds like a Changelog entry. +BUILD_DEPENDS=3D ninja:devel/ninja \ ninja is implied by USES=3Dcmake +USES=3D cmake:outsource \ + pkgconfig This should all be on one line. +USE_XORG+=3D x11 ice sm xext +USE_GL+=3D gl Please replace +=3D with =3D. +USE_GITHUB=3D yes +GH_ACCOUNT=3D Yoshimi +GH_PROJECT=3D yoshimi +GH_TAGNAME=3D 31291f0 GH_{PROJECT,ACCOUNT} are set to ${PORTNAME} by default. GitHub project and account names are also case-insentive, so both GH_{PROJECT,ACCOUNT} can go away here. +MAKE_JOBS_UNSAFE=3D yes Why is this set? +.include ... +.include This isn't necessary here. Just use .include at the end. +post-install: + @(mv ${STAGEDIR}${PREFIX}/share/man/man1/yoshimi.1 ${STAGEDIR}${PREFIX}/share/man/yoshimi.1 && \ + ${RM} -rf ${STAGEDIR}${PREFIX}/share/man/man1 && \ + ${GZIP_CMD} ${STAGEDIR}${PREFIX}/share/man/yoshimi.1); mv should be ${MV}. > I also had to manually move and gzip the manual file and that causes > portlint -AC to complain: It complains because you moved it into the wrong place ;-). Moving it to ${PREFIX}/share/man is wrong. It needs to go into ${PREFIX}/man/man1. Gzipping man pages is done automatically when there're installed into the right location. +%%DATADIR%%/yoshimi-user-manual.pdf This should probably go into ${DOCSDIR} too. --=20 You are receiving this mail because: You are the assignee for the bug.=