From owner-svn-src-head@freebsd.org Tue Nov 10 16:19:51 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DAA28A2BECE for ; Tue, 10 Nov 2015 16:19:51 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 631F91C04 for ; Tue, 10 Nov 2015 16:19:51 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by lfs39 with SMTP id 39so935342lfs.3 for ; Tue, 10 Nov 2015 08:19:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=tjWdaLCu5hj4eQNuZLNiVQBjcgV6Jy+MUNB0yvtZQ5Q=; b=cJpuX/E8+JxWfB4lqwQBw/y1B2ykwJD2j1pybHtjU3nL1W546D16bQPej77Zmh7SOX KSxyL+BRWPVUC9EGEFz4+akyQHm3KIivZ1yMAgBh3Zu7JvXEGoNicPA61Rsy8sA5o0fR RWZMrZJZ8LHP9F4nuorDe7prGKxlefShcgvxjXxNiaTpf5eyOCvQ8464fdDr15gu2imp Z6MqSWaeBs27AdjHQaFNazXNNmkYKniA0wvWk8EDisqejxqSS7tO0P1EjmOk3RJaGCHD DuaAR1SqMj3r6mcIzM2ek/RzFQfjqxUQj77kfumRQ1D29UwXlnC4AMR2tj12gZb8OWJs exdQ== X-Gm-Message-State: ALoCoQmwC2+SMXig/W8ZMamqg/fGBtMxmpRHE0Hztw7mLF9CbXtsWgx+CQxYMvCXWGm4+vbEp/fm X-Received: by 10.25.211.210 with SMTP id k201mr1764310lfg.30.1447172389308; Tue, 10 Nov 2015 08:19:49 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id k1sm655730lfe.23.2015.11.10.08.19.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 08:19:48 -0800 (PST) Subject: Re: svn commit: r290637 - head/lib/libc/locale To: Baptiste Daroussin References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org> <20151110133615.GL10134@ivaldir.etoilebsd.net> <5642163E.1050405@freebsd.org> <20151110161204.GM10134@ivaldir.etoilebsd.net> Cc: tcltk@FreeBSD.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org From: Andrey Chernov Message-ID: <56421923.7080601@freebsd.org> Date: Tue, 10 Nov 2015 19:19:47 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151110161204.GM10134@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PuKg2eHPNNvjl8UeQ6v8WHta5mjDtdWw2" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 16:19:51 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PuKg2eHPNNvjl8UeQ6v8WHta5mjDtdWw2 Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 10.11.2015 19:12, Baptiste Daroussin wrote: > On Tue, Nov 10, 2015 at 07:07:26PM +0300, Andrey Chernov wrote: >> On 10.11.2015 16:36, Baptiste Daroussin wrote: >>> On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: >>>> On 10.11.2015 16:04, Baptiste Daroussin wrote: >>>>> On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: >>>>>> On 10.11.2015 11:11, Baptiste Daroussin wrote: >>>>>>> Author: bapt >>>>>>> Date: Tue Nov 10 08:11:27 2015 >>>>>>> New Revision: 290637 >>>>>>> URL: https://svnweb.freebsd.org/changeset/base/290637 >>>>>>> >>>>>>> Log: >>>>>>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" locale= s >>>>>>> as it used to be in previous version of the locales. Returning >>>>>>> "POSIX" has too many fallouts. >>>>>> >>>>>> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to be= >>>>>> different with real US-ASCII. It is what glibc returns for C/POSIX= >>>>>> locale and most ports expected, being linux-oriented. >>>>>> >>>>> I thought about it, but in the end it is probably safer for now tha= t nl_langinfo >>>>> return US-ASCII as it did in the past, to reduce breakage with Free= BSD only code >>>>> that maybe be existing ou there. >>>> >>>> All FreeBSD code I know never check locale this way. IMHO probabilit= y of >>>> potential danger to meet some linux-oriented port with this check is= >>>> much much higher than to meet similar FreeBSD only code in the wild.= In >>>> any case, changing collate order from A-Za-z to aA-zZ we do just now= >>>> have much higher probability to break unknown FreeBSD only code, so = one >>>> breaking change can go with other one together. >>>> >>> That is true, except that the new collation thing is invalidated as s= oon as you >>> set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a wor= karound while >>> changing the return value of nl_langinfo() is not workaroundable. >> >> Well, forget my improper comparison with collate and see this bug in >> action right now, in our port tcl8.6.4/unix/tclUnixInit.c: >> >> See localeTable and comment above it, there is internal "ansi_x3.4-196= 8" >> (i.e. POSIX locale), internal "ascii" and even no alias for our >> "us-ascii" at all. >> >> It gets info through nl_langinfo(CODESET), lowercased. I.e. not using >> "ANSI_X3.4-1968" breaks all tcl ports right now, this is more essentia= l >> than hypothetical private FreeBSD only code no one see. >=20 > That one is a valid point, that also means that is is broken right now = on > FreeBSD 10 and below? Yes. It can't map our C locale to the some of internal ones and falls back to TCL_DEFAULT_ENCODING "iso8859-1" --=20 http://ache.vniz.net/ --PuKg2eHPNNvjl8UeQ6v8WHta5mjDtdWw2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJWQhkjAAoJEKUckv0MjfbKZJ8H/1WmexGjac80HoT4GC1YoiZc 1tHQqlfakh3619HpOTw3biKdWOjVH1wpVxTNin/yelA9REmKhH6IM+T29Wk5MjvV tCM/B+PPDLa5tbgSfH6+V9PdCtSDvSK9U62oBWtgdexekYv3Pvno0e0e9vkbVm0H 34mGw/w6uyUVtrMtTrIG9xr9O5RK3BL7xJV9heTstI4vyeVrQcb4Sl4VmSEny8y0 wRhqBbPfgzejv9sS4Df00hdvZ8TSLxirrGkPwSi64KOfhJBub9U6HIlvm98ePgcc Gfwf2yDjLA4jvqe2Eemd7fTTJPBvThJCcFdEOUWtweGNWjlhFGdjRqPjrjLLB3M= =c9LU -----END PGP SIGNATURE----- --PuKg2eHPNNvjl8UeQ6v8WHta5mjDtdWw2--