Date: Thu, 28 Apr 2016 15:19:02 +0000 From: "gallatin (Andrew Gallatin)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D6137: tcp/lro: Refactor the free/active list operation. Message-ID: <5a62357bc12a09453564ba3ff2bc34b5@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-mroevi6nzobvlsf24xxb-req@FreeBSD.org> References: <differential-rev-PHID-DREV-mroevi6nzobvlsf24xxb-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
gallatin added a comment. The tcp_lro_entry_get() abstraction adds an extra compare to the critical path (the compare against NULL in the function itself, in addition to the same compare in the main routine). At least it does at the C level. Have you verified that the compiler is smart enough to continue to use a single compare? If this adds an extra compare to the actual executed code, then I object. REVISION DETAIL https://reviews.freebsd.org/D6137 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, transport, rrs, adrian, delphij, glebius, hselasky, np, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, gallatin Cc: freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5a62357bc12a09453564ba3ff2bc34b5>