From owner-cvs-all@FreeBSD.ORG Tue Aug 31 19:36:29 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B283616A4E0 for ; Tue, 31 Aug 2004 19:36:29 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 566E843D5A for ; Tue, 31 Aug 2004 19:36:29 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 26395 invoked from network); 31 Aug 2004 19:36:28 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 31 Aug 2004 19:36:28 -0000 Received: from [10.50.41.228] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i7VJaGUV052999; Tue, 31 Aug 2004 15:36:24 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Yar Tikhiy Date: Tue, 31 Aug 2004 14:05:04 -0400 User-Agent: KMail/1.6.2 References: <200408280839.i7S8dZpI097103@repoman.freebsd.org> <200408301141.00176.jhb@FreeBSD.org> <20040831050853.GA75766@comp.chem.msu.su> In-Reply-To: <20040831050853.GA75766@comp.chem.msu.su> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200408311405.04310.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/mbr Makefile mbr.s X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2004 19:36:30 -0000 On Tuesday 31 August 2004 01:08 am, Yar Tikhiy wrote: > On Mon, Aug 30, 2004 at 11:41:00AM -0400, John Baldwin wrote: > > On Saturday 28 August 2004 04:39 am, Yar Tikhiy wrote: > > > yar 2004-08-28 08:39:35 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/boot/i386/mbr Makefile mbr.s > > > Log: > > > Don't be too smart, just try packet mode of INT13 first. > > > This way of operation is more robust than the "AI" used > > > before. > > > > > > Add flags to mbr accessible from make.conf as BOOT_MBR_FLAGS. > > > Only one flag is defined now, "allow using packet mode", which > > > is 0x80 in accord with the rest of i386 boot code. The "packet" > > > flag is on by default. > > > > > > PR: i386/70241 > > > Submitted by: Valentin Nechayev netch.kiev.ua> (inital > > > version) Discussed with: jhb (by Valentin Nechayev) > > > Tested on: bochs (with EDD turned on or off by patching the > > > BIOS), PCs > > > > > > Revision Changes Path > > > 1.14 +4 -0 src/sys/boot/i386/mbr/Makefile > > > 1.7 +6 -6 src/sys/boot/i386/mbr/mbr.s > > > > Hmm, there are no e-mails from me in the PR trail and I don't recall ever > > be in favor of these changes (though I don't care enough to ask for them > > to be backed out.. Only really old machines with pre-1995 BIOS should be > > broken in theory.) It would be nice if you wouldn't claim that I > > supported something that I didn't actually support though. > > John, I try to believe people as much as possible since that saves > my time, and I believe Valentin Nechayev particularly because I know > him quite well. Here are his words straight from the PR: > > %%% > > >Fix: > > Revert logic of selection between traditional and EDD reading mode > to one which prefers EDD if available (as was in the same file in revisions > 1.11 and 1.12). This is supported by John Baldwin (private conversation > after thread in hackers@): > ==={{{ > The problem is that there are BIOS's out there that claim to support EDD > but still don't work correctly. I don't remember all the details at this > point, but I think it had to do with sysinstall not always being in sync > with the BIOS about how sectors were in a cylinder. I guess though we > could just turn EDD on by default in 5.x or perhaps 6.0. 5.x doesn't > really run well on a 386 or even a 486, and that is the class of machine > that has problems with EDD. > ===}}} > > %%% > > I know it could be hard on memory to return to issues one used to > work at in the past, so I decided not to bother you to confirm if > that quote is actually yours. Please excuse me if it was a poor > idea of mine. Hmm, maybe my memory is worse. I found some e-mails in my archive when I searched but not this one. The quoted e-mail above is mine and is correct. I guess I kind of forgot that this was a 6.0 change and 6.0 won't be out for a while. My apologies for getting all jumpy. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org