From owner-cvs-all Thu Mar 22 10:27: 9 2001 Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 34CCE37B71F; Thu, 22 Mar 2001 10:27:03 -0800 (PST) (envelope-from bright@fw.wintelcom.net) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id f2MIR0407346; Thu, 22 Mar 2001 10:27:00 -0800 (PST) Date: Thu, 22 Mar 2001 10:26:59 -0800 From: Alfred Perlstein To: Garrett Wollman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/rpc clnt_vc.c svc_vc.c src/sys/sys socket.h src/usr.sbin/rpcbind pmap_svc.c rpcb_svc_com.c src/usr.sbin/keyserv Makefile keyserv.c keyserv.h keyserv_uid.c Message-ID: <20010322102659.T9431@fw.wintelcom.net> References: <200103220431.f2M4VUi82231@freefall.freebsd.org> <200103221541.KAA30165@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200103221541.KAA30165@khavrinen.lcs.mit.edu>; from wollman@khavrinen.lcs.mit.edu on Thu, Mar 22, 2001 at 10:41:08AM -0500 X-all-your-base: are belong to us. Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Garrett Wollman [010322 07:41] wrote: > < said: > > > Make struct cmessage visible from socket.h (about 4 places were > > defining it for themselves which wasn't good) > > This change is 100% bogus, and introduces additional unnecessary > namespace pollution. The correct way to access the data of a control > message is by using the CMSG_DATA() macro. Yeah, but it's disgusting, at least I can't see a sane way of declaring the cmessage type without using it, here's what you can do: 1) leave it in sys/socket.h 2) put the cmessage struct in each file 3) declare consumers of cmessage as so: struct { struct cmsghdr cmsg; struct cmsgcred cmcred; } cm; 4) or do this: char cm[sizeof(struct cmsghdr) + sizeof(struct cmsgcred)]; I'll wait for you to decide or point to something that I can crib from. thanks, -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message