From owner-freebsd-threads@FreeBSD.ORG Fri Oct 29 01:08:26 2004 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D30216A4E4; Fri, 29 Oct 2004 01:08:26 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8D0A43D1F; Fri, 29 Oct 2004 01:08:25 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) i9T18MIo012748; Thu, 28 Oct 2004 21:08:22 -0400 (EDT) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id i9T18MTi012747; Thu, 28 Oct 2004 21:08:22 -0400 (EDT) Date: Thu, 28 Oct 2004 21:08:22 -0400 From: Ken Smith To: Julian Elischer Message-ID: <20041029010822.GA12081@electra.cse.Buffalo.EDU> References: <41817EE4.9080302@elischer.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline In-Reply-To: <41817EE4.9080302@elischer.org> User-Agent: Mutt/1.4.1i cc: Daniel Eischen cc: threads@freebsd.org cc: re@freebsd.org cc: David Xu cc: John Baldwin Subject: Re: MFC req for 5.x/5.3 X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2004 01:08:26 -0000 --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 28, 2004 at 04:21:08PM -0700, Julian Elischer wrote: > Daniel Eischen wrote: > >On Thu, 28 Oct 2004, Julian Elischer wrote: > >>David Xu wrote: > >>>Here is the cvs log: > >>> > >>>Revision Changes Path > >>> 1.58 +1 -0 src/lib/libpthread/thread/thr_create.c > >>> 1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c > >>> 1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c > >>> 1.119 +15 -11 src/lib/libpthread/thread/thr_private.h > >>> 1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c > >>> > >>commit message was: > >>1. Move thread list flags into new separate member, and atomically > >> put DEAD thread on GC list, this closes a race between pthread_join > >> and thr_cleanup. > >>2. Introduce a mutex to protect tcb initialization, tls allocation and > >> deallocation code in rtld seems no lock protection or it is broken, > >> under stress testing, memory is corrupted. > >> > >>translates to: > >> >=20 > [diff removed] >=20 > > > >Yes, these look right. > > Ok. If you have done a complete buildworld/installworld test on RELENG_5 with the patches you sent please MFC it to RELENG_5 and RELENG_5_3. If you haven't done a complete buildworld/installworld test with these patches please just MFC to RELENG_5 and let me know, I'll test it there before we do the jump to RELENG_5_3. Sorry for being this jumpy about it but this does look like a slightly complicated MFC. It looks like there had been other changes to libpthread/thread between the RELENG_5 branch and now that you are not MFC-ing at this point. I need to do tags slips with what hits RELENG_5_3 so I need to be a bit careful with what gets that far. And I know not everyone has a ton of machines around they can test the various stages on so if it's a bit hard for you to do the full buildworld/installworld tests I can take care of that for you. Thanks. --=20 Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (SunOS) iD8DBQFBgZgE/G14VSmup/YRAt6dAJwPX+3XqCnWiU7o1i/JhhrenbMcjgCgi7ns bSc7E/lCARFOE2l3d02GNxE= =oGVe -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn--