From owner-freebsd-usb@FreeBSD.ORG Fri May 7 03:50:01 2010 Return-Path: Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9A65B106566B for ; Fri, 7 May 2010 03:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 5FF338FC1A for ; Fri, 7 May 2010 03:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o473o1f2072074 for ; Fri, 7 May 2010 03:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o473o1eN072073; Fri, 7 May 2010 03:50:01 GMT (envelope-from gnats) Resent-Date: Fri, 7 May 2010 03:50:01 GMT Resent-Message-Id: <201005070350.o473o1eN072073@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-usb@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alex Deiter Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D36D51065674 for ; Fri, 7 May 2010 03:49:43 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.freebsd.org (Postfix) with ESMTP id C40828FC13 for ; Fri, 7 May 2010 03:49:43 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o473nhf2065851 for ; Fri, 7 May 2010 03:49:43 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o473nhSF065849; Fri, 7 May 2010 03:49:43 GMT (envelope-from nobody) Message-Id: <201005070349.o473nhSF065849@www.freebsd.org> Date: Fri, 7 May 2010 03:49:43 GMT From: Alex Deiter To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2010 03:50:01 -0000 >Number: 146367 >Category: usb >Synopsis: [PATCH] Revision 205728: broken bluetooth mouse support >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-usb >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri May 07 03:50:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Alex Deiter >Release: 9.0 >Organization: N/A >Environment: today 9.0-current (Revision 207680) >Description: Hi, Bluetooth mouse support is broken after Revision 205728: http://svn.freebsd.org/viewvc/base?view=revision&revision=205728 When I move the mouse - cursor stays in same place but moves the current position of the console. Proposed patch as an attachment. Could you please revew this ? Thanks a lot! >How-To-Repeat: >Fix: please review patch Patch attached with submission follows: --- lib/libusbhid/data.c.orig 2010-05-07 01:26:45.192120194 +0400 +++ lib/libusbhid/data.c 2010-05-07 01:55:56.114702254 +0400 @@ -40,15 +40,10 @@ const uint8_t *buf; uint32_t hpos; uint32_t hsize; - uint32_t data; + int32_t data; int i, end, offs; buf = p; - - /* Skip report ID byte. */ - if (h->report_ID > 0) - buf++; - hpos = h->pos; /* bit position of data */ hsize = h->report_size; /* bit length of data */ >Release-Note: >Audit-Trail: >Unformatted: