Date: Tue, 04 Nov 2014 22:24:14 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 194825] [PATCH] Make sysutils/mcelog build on DragonFly Message-ID: <bug-194825-13-rVh8RouFMA@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-194825-13@https.bugs.freebsd.org/bugzilla/> References: <bug-194825-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194825 Jeremy Chadwick <jdc@koitsu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|maintainer-feedback?(jdc@ko |maintainer-feedback+ |itsu.org) | --- Comment #2 from Jeremy Chadwick <jdc@koitsu.org> --- I approve of this patch (updating Makefile and files/patch-Makefile. One thing I want to make clear here, however: the CFLAGS definition (of -Os -g) in the software's Makefile is somewhat justified. If you read the top of that Makefile, they explain why: it has to do with compiler warning flags catching certain scenarios only when -Os is in use (compared to just -O2 or -O or stock defaults). That's something that needs to be kept in mind going forward. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194825-13-rVh8RouFMA>