From owner-freebsd-bugs@FreeBSD.ORG Wed Nov 24 17:40:07 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0051C106566C for ; Wed, 24 Nov 2010 17:40:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CA84E8FC1A for ; Wed, 24 Nov 2010 17:40:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAOHe6d8023836 for ; Wed, 24 Nov 2010 17:40:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAOHe6tP023835; Wed, 24 Nov 2010 17:40:06 GMT (envelope-from gnats) Resent-Date: Wed, 24 Nov 2010 17:40:06 GMT Resent-Message-Id: <201011241740.oAOHe6tP023835@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henning Petersen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5FB5C1065670 for ; Wed, 24 Nov 2010 17:31:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 4E5208FC1E for ; Wed, 24 Nov 2010 17:31:06 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oAOHV5Lo043569 for ; Wed, 24 Nov 2010 17:31:05 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id oAOHV5pu043568; Wed, 24 Nov 2010 17:31:05 GMT (envelope-from nobody) Message-Id: <201011241731.oAOHV5pu043568@red.freebsd.org> Date: Wed, 24 Nov 2010 17:31:05 GMT From: Henning Petersen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/152549: The function catstrg() in usr.bin/xlint/lint1/tree.c is broken. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2010 17:40:07 -0000 >Number: 152549 >Category: bin >Synopsis: The function catstrg() in usr.bin/xlint/lint1/tree.c is broken. >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Nov 24 17:40:06 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Henning Petersen >Release: FreeBSD-current >Organization: >Environment: >Description: The function catstrg() in usr.bin/xlint/lint1/tree.c is broken. >How-To-Repeat: Take the following example program: ---- BEGIN ----- #include #include #include /* PRINTFLIKE1 */ int myprintf(char *fmt0, ...) { va_list va; va_start(va, fmt0); vsyslog(LOG_DEBUG, fmt0, va); va_end(va); return 0; } int main(int argc, char *argv[]) { long h; h = (long) argc; myprintf("Usage: " "%ld [options]\n" , h); return argv[0] != NULL; } ---- END ----- and run lint -n example.c which will print (besides other stuff): myprintf: malformed format string >Fix: diff -u -r1.14 tree.c --- src/usr.bin/xlint/lint1/tree.c 1 Jan 2003 18:13:44 -0000 1.14 +++ src/usr.bin/xlint/lint1/tree.c 24 Nov 2010 16:23:32 -0000 @@ -3786,6 +3786,7 @@ (len2 + 1) * sizeof (wchar_t)); free(strg2->st_wcp); } + strg1->st_len = len; free(strg2); return (strg1); Patch attached with submission follows: Index: src/usr.bin/xlint/lint1/tree.c =================================================================== RCS file: /home/ncvs/src/usr.bin/xlint/lint1/tree.c,v retrieving revision 1.14 diff -u -r1.14 tree.c --- src/usr.bin/xlint/lint1/tree.c 1 Jan 2003 18:13:44 -0000 1.14 +++ src/usr.bin/xlint/lint1/tree.c 24 Nov 2010 16:23:32 -0000 @@ -3786,6 +3786,7 @@ (len2 + 1) * sizeof (wchar_t)); free(strg2->st_wcp); } + strg1->st_len = len; free(strg2); return (strg1); >Release-Note: >Audit-Trail: >Unformatted: