From owner-freebsd-fs@FreeBSD.ORG Tue Oct 11 10:36:54 2011 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3847B106564A for ; Tue, 11 Oct 2011 10:36:54 +0000 (UTC) (envelope-from se@freebsd.org) Received: from nm23-vm0.bullet.mail.bf1.yahoo.com (nm23-vm0.bullet.mail.bf1.yahoo.com [98.139.212.191]) by mx1.freebsd.org (Postfix) with SMTP id DFE6F8FC12 for ; Tue, 11 Oct 2011 10:36:53 +0000 (UTC) Received: from [98.139.212.151] by nm23.bullet.mail.bf1.yahoo.com with NNFMP; 11 Oct 2011 10:22:48 -0000 Received: from [98.139.213.8] by tm8.bullet.mail.bf1.yahoo.com with NNFMP; 11 Oct 2011 10:22:48 -0000 Received: from [127.0.0.1] by smtp108.mail.bf1.yahoo.com with NNFMP; 11 Oct 2011 10:22:48 -0000 X-Yahoo-Newman-Id: 810738.28270.bm@smtp108.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: HU7UUGoVM1lQCFLiUMuFczva6gupKGKdp6AZxDCmoBlBNnL dgvpm.EbGAi4h6ED9mn6kwMByl6SFPvrGj9qW3B3_wVEVwNybM8ox3kdlqmR tLNbGouFEbdipAUdXsIXV3eCQXblg7sxrCqP4BA8ud29yoEE9nZauPVVk.ab Bxycilk3cwz1qc7oHBVXl_3C40MsHukCoO1nwSy7U4RTkUSYv4hwpojnazvs U7vp8dUay8ehPgXgyq0rGZttQqTSQgalpTAkW7bK0X_scGP_Lrra.1ynmYG_ jzKi7jErkj5fHFLlFWoVwgO933PI5MifuvJVBl92q1aLF9M232F5xlEo.Bdr kJvK4vYLsBHqG9Lwi0euwsB.jPk4PeYch5uUOCFvzUY7D5O09h6DGkSLAwwo hL.ZosNpcQdMspfAW X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. Received: from [192.168.119.20] (se@81.173.155.124 with plain) by smtp108.mail.bf1.yahoo.com with SMTP; 11 Oct 2011 03:22:48 -0700 PDT Message-ID: <4E9418F9.9030304@freebsd.org> Date: Tue, 11 Oct 2011 12:22:49 +0200 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: mm@FreeBSD.org References: <201110110726.p9B7QhEC072913@freefall.freebsd.org> In-Reply-To: <201110110726.p9B7QhEC072913@freefall.freebsd.org> Content-Type: multipart/mixed; boundary="------------020706090101080007040807" Cc: freebsd-fs@FreeBSD.org, sm@kill-9.net Subject: [RESENT with patch] Re: bin/121366: [zfs] [patch] Automatic disk scrubbing from periodic(8) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2011 10:36:54 -0000 This is a multi-part message in MIME format. --------------020706090101080007040807 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit On 11.10.2011 09:26, mm@FreeBSD.org wrote: > Synopsis: [zfs] [patch] Automatic disk scrubbing from periodic(8) > > State-Changed-From-To: open->closed > State-Changed-By: mm > State-Changed-When: Tue Oct 11 07:26:43 UTC 2011 > State-Changed-Why: > Implemented in r209195 by netchild@ (/etc/periodic/daily/800.scrub-zfs) > > http://www.freebsd.org/cgi/query-pr.cgi?pr=121366 There is no mention of daily_scrub_zfs_enable daily_scrub_zfs_pools daily_scrub_zfs_default_threshold daily_scrub_zfs_${poolname}_threshold in /etc/defaults/periodic.conf, which we use to define configuration options for all periodic scripts. The attached patch adds the missing entries. I'm not sure about the commented out line for "daily_scrub_zfs_${poolname}_threshold", but there is precedent (in the "amd" section) and I think many users will grep for scrub_zfs in that file instead of looking into the man-page for periodic.conf. If the defaults in the patch are considered OK (they just state the defaults set in the script), I'd like to commit them to head and MFC within a week. Regards, STefan (Please include my address in replies, since I'm not in freebsd-fs@). PS: The following unrelated variables have no defaults defined: daily_backup_distfile_enable daily_backup_pkgdb_dbdir daily_distfile_enable I have not yet looked up their defaults, but I think they should also be defined in defaults/periodic.conf ... --------------020706090101080007040807 Content-Type: text/plain; name="periodic.conf.zfs-scrub.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="periodic.conf.zfs-scrub.diff" --- /usr/src/etc/defaults/periodic.conf~ 2011-03-26 19:33:15.000000000 +0100 --- /usr/src/etc/defaults/periodic.conf 2011-10-11 11:34:09.245775412 +0200 @@ -205,6 +205,12 @@ # 800.loginfail daily_status_security_loginfail_enable="YES" +# 800.scrub-zfs +daily_scrub_zfs_enable="NO" +daily_scrub_zfs_pools="" # empty string selects all pools +daily_scrub_zfs_default_threshold="30" # days between scrubs +#daily_scrub_zfs_${poolname}_threshold="30" # pool specific threshold + # 900.tcpwrap daily_status_security_tcpwrap_enable="YES" --------------020706090101080007040807--