From owner-freebsd-ports@FreeBSD.ORG  Tue Mar 20 00:12:36 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C3AD21065670
	for <freebsd-ports@freebsd.org>; Tue, 20 Mar 2012 00:12:36 +0000 (UTC)
	(envelope-from ade@FreeBSD.org)
Received: from panix.lovett.com (panix.lovett.com [166.84.7.128])
	by mx1.freebsd.org (Postfix) with ESMTP id 99B378FC16
	for <freebsd-ports@freebsd.org>; Tue, 20 Mar 2012 00:12:36 +0000 (UTC)
Received: from nat-dip7.cfw-a-gci.corp.yahoo.com ([209.131.62.116]
	helo=[10.72.180.251])
	by panix.lovett.com with esmtpa (Exim 4.77 (FreeBSD))
	(envelope-from <ade@FreeBSD.org>) id 1S9mPf-000C0E-06
	for freebsd-ports@freebsd.org; Mon, 19 Mar 2012 23:54:55 +0000
Message-ID: <4F67C74D.2080906@FreeBSD.org>
Date: Mon, 19 Mar 2012 16:54:53 -0700
From: Ade Lovett <ade@FreeBSD.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: freebsd-ports@freebsd.org
References: <20120319075901.GA16256@snail.casa> <4F67BE27.7030400@FreeBSD.org>
In-Reply-To: <4F67BE27.7030400@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] proposal for x11-wm/windowmaker
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2012 00:12:36 -0000

On 3/19/2012 16:15, Doug Barton wrote:
> On 3/19/2012 12:59 AM, Arrigo Marchiori wrote:
>> Hello,
>>
>> I am attaching a "quick-and-dirty" patch that should reallow
>> compilation of x11-wm/windowmaker under 7-STABLE.
>>
>> The problem seems to be the missing macro HAVE_SYS_SELECT_H; the patch
>> just forces it in the configure script if a FreeBSD system is
>> detected.
>
> I'm not opposed to adding that if someone can confirm that it allows
> WindowMaker to compile on 7-stable.

Since it's for 7-stable only (apparently), it would be better off 
wrapped in an OSVERSION check to make things abundantly clear as to why 
it's being done.

-aDe