Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Dec 2002 00:07:34 GMT
From:      Mark Valentine <mark@thuvia.demon.co.uk>
To:        phk@freebsd.org (Poul-Henning Kamp), cvs-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/sys _iovec.h socket.h uio.h
Message-ID:  <200212290007.gBT07YVO012379@dotar.thuvia.org>
In-Reply-To: <mailpost.1041113940.9911@thuvia.demon.co.uk>

next in thread | previous in thread | raw e-mail | index | archive | help
> From: phk@freebsd.org (Poul-Henning Kamp)
> Date: Sat 28 Dec, 2002
> Subject: cvs commit: src/sys/sys _iovec.h socket.h uio.h

> phk         2002/12/28 14:17:29 PST
> 
>   Modified files:
>     sys/sys              socket.h uio.h 
>   Added files:
>     sys/sys              _iovec.h 
>   Log:
>
>   ...
>
>   Sensible people could just put iovec into sys/_types.h but there
>   is probably some standard or other which will be violated if we
>   did something that horrible.

Actually, the IEEE Std 1003.1-2001 spec. for <sys/socket.h> states:

    "Inclusion of <sys/socket.h> may also make visible all symbols
    from <sys/uio.h>."

So, it seems it would be sufficient to have a single definition of
struct iovec in <sys/uio.h>.

It would seem to also work having it in <sys/types.h>, since both
interfaces from <sys/uio.h> and some from <sys/socket.h> use ssize_t
and/or size_t, but this should be considered accidental.

Having said that, your implementation works too.

		Cheers,

		Mark.

-- 
Mark Valentine, Thuvia Labs <mark@thuvia.co.uk>       <http://www.thuvia.co.uk>;
"Tigers will do ANYTHING for a tuna fish sandwich."       Mark Valentine uses
"We're kind of stupid that way."   *munch* *munch*        and endorses FreeBSD
  -- <http://www.calvinandhobbes.com>;                  <http://www.freebsd.org>;

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200212290007.gBT07YVO012379>