From owner-cvs-all@FreeBSD.ORG Mon Feb 14 19:56:00 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19B8016A4CE; Mon, 14 Feb 2005 19:56:00 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2CE2743D41; Mon, 14 Feb 2005 19:55:59 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j1EJttQS026070; Mon, 14 Feb 2005 21:55:55 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 71162-05; Mon, 14 Feb 2005 21:55:54 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j1EJtsc0026067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 14 Feb 2005 21:55:54 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id j1EJtwi0070320; Mon, 14 Feb 2005 21:55:58 +0200 (EET) (envelope-from ru) Date: Mon, 14 Feb 2005 21:55:58 +0200 From: Ruslan Ermilov To: Sam Leffler Message-ID: <20050214195558.GD69635@ip.net.ua> References: <200502140829.j1E8TgDs086634@repoman.freebsd.org> <4210D210.3080700@errno.com> <20050214181431.GA69635@ip.net.ua> <4210F849.8060005@errno.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZJcv+A0YCCLh2VIg" Content-Disposition: inline In-Reply-To: <4210F849.8060005@errno.com> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2005 19:56:00 -0000 --ZJcv+A0YCCLh2VIg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 14, 2005 at 11:13:13AM -0800, Sam Leffler wrote: > >>This also has the potential to noticeably=20 > >>affect performance so I think a better solution is needed. > > > >Here are my thoughts. On a typical input path, there will be > >either one or zero mtags, one if driver provided us with the > >VLAN mtag, so effectively we replaced "ifp->if_nvlans" with > >"m_tag_first(m) !=3D NULL", and this doesn't look like a huge > >performance downgrade to me, if at all. >=20 > The intent was/is that if_nvlans be the definitive check for whether or= =20 > not one should inspect the tag chain for vlan tags. This effectively=20 > renders that assumption invalid. I think it would better to discard=20 > these frames in the driver rather than allocate a tag, pass it up, then= =20 > discard it in ether_demux. I think you could encapsulate the check in=20 > VLAN_INPUT_TAG. >=20 I said this before: vlan(4) is not the only consumer of VLAN frames in FreeBSD. VLAN frames are also accepted by ng_vlan(4), so using the vlan(4)-specific if_nvlans to decide whether we should accept VLAN frames (in the driver) just isn't appropriate. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --ZJcv+A0YCCLh2VIg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFCEQJOqRfpzJluFF4RArqWAJ4nebCnnEqH9bY70nRcsIHBccSpygCcCgy6 iFW2jaRYMsBIImp9B4KQk0s= =8o75 -----END PGP SIGNATURE----- --ZJcv+A0YCCLh2VIg--