From owner-freebsd-current@FreeBSD.ORG Tue Dec 2 22:09:57 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5CC8516A4CE; Tue, 2 Dec 2003 22:09:57 -0800 (PST) Received: from hak.cnd.mcgill.ca (hak.cnd.mcgill.ca [132.216.11.133]) by mx1.FreeBSD.org (Postfix) with ESMTP id 07AF543FA3; Tue, 2 Dec 2003 22:09:54 -0800 (PST) (envelope-from mat@hak.cnd.mcgill.ca) Received: from hak.cnd.mcgill.ca (localhost [127.0.0.1]) by hak.cnd.mcgill.ca (8.12.9/8.12.8) with ESMTP id hB367A15065553; Wed, 3 Dec 2003 01:07:10 -0500 (EST) (envelope-from mat@hak.cnd.mcgill.ca) Received: (from mat@localhost) by hak.cnd.mcgill.ca (8.12.9/8.12.8/Submit) id hB367A6v065552; Wed, 3 Dec 2003 01:07:10 -0500 (EST) Date: Wed, 3 Dec 2003 01:07:10 -0500 From: Mathew Kanner To: Jesse Guardiani , Sean Chittenden , freebsd-current@FreeBSD.org Message-ID: <20031203060710.GJ54011@cnd.mcgill.ca> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="G4iJoqBmSsgzjUCe" Content-Disposition: inline User-Agent: Mutt/1.4.1i Organization: I speak for myself, operating in Montreal, CANADA X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.60 X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on hak.cnd.mcgill.ca Subject: please test pcm channel patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Dec 2003 06:09:57 -0000 --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello All, Please test this PCM patch. It creates seperate locking classes for PCM channels and should prevent the warning where multiple mutexes from the same class are held (as reported recently). I believe this to be a good strategy as it masks fewer errors. Thanks, --mat -- The state has no business in the bedrooms of the nation. - Pierre Elliott Trudeau --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="channel_lor2.patch" Index: channel.c =================================================================== RCS file: /home/ncvs/src/sys/dev/sound/pcm/channel.c,v retrieving revision 1.92 diff -u -r1.92 channel.c --- channel.c 27 Nov 2003 19:51:44 -0000 1.92 +++ channel.c 3 Dec 2003 05:59:56 -0000 @@ -69,7 +69,10 @@ static void chn_lockinit(struct pcm_channel *c) { - c->lock = snd_mtxcreate(c->name, "pcm channel"); + if (c->direction == PCMDIR_PLAY) + c->lock = snd_mtxcreate(c->name, "pcm play channel"); + else + c->lock = snd_mtxcreate(c->name, "pcm record channel"); } static void --G4iJoqBmSsgzjUCe--