From owner-freebsd-bugs@FreeBSD.ORG  Thu Jul 17 13:01:02 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1898C106567C
	for <freebsd-bugs@FreeBSD.org>; Thu, 17 Jul 2008 13:01:02 +0000 (UTC)
	(envelope-from arne_woerner@yahoo.com)
Received: from web30301.mail.mud.yahoo.com (web30301.mail.mud.yahoo.com
	[209.191.69.63]) by mx1.freebsd.org (Postfix) with SMTP id BB4D58FC15
	for <freebsd-bugs@FreeBSD.org>; Thu, 17 Jul 2008 13:01:01 +0000 (UTC)
	(envelope-from arne_woerner@yahoo.com)
Received: (qmail 53511 invoked by uid 60001); 17 Jul 2008 12:34:21 -0000
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com;
	h=Received:X-Mailer:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID;
	b=MTMYJWlXRxAYr4zdfIrceUAQF7lVpf1DFSjA90Ji7c8DzcpX8AUUE7Ym3LnJW7QTxof5mVF6sZVNVXoJPl9E0l0sLI7ft7x1bA1GIFT2rgz3h3r9W5tAtAJa5Q71QIuKHqoC3hIWFvMitTior0mjx4okaQlUEDFvAfx57GkKmMc=;
Received: from [79.223.95.240] by web30301.mail.mud.yahoo.com via HTTP;
	Thu, 17 Jul 2008 05:34:21 PDT
X-Mailer: YahooMailWebService/0.7.218
Date: Thu, 17 Jul 2008 05:34:21 -0700 (PDT)
From: =?iso-8859-1?Q?Arne_W=F6rner?= <arne_woerner@yahoo.com>
To: gavin@FreeBSD.org, freebsd-bugs@FreeBSD.org
In-Reply-To: <200807171211.m6HCBYfO092980@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Message-ID: <608836.52903.qm@web30301.mail.mud.yahoo.com>
Cc: 
Subject: Re: bin/100018: newsyslog(8) does not check size if time_at is used
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jul 2008 13:01:02 -0000

--- On Thu, 7/17/08, gavin@FreeBSD.org <gavin@FreeBSD.org> wrote:
> -=09=09} else if (ent->hours <=3D 0 &&
> (ent->flags & CE_TRIMAT)) {
> +=09=09} else if ((ent->hours <=3D 0 &&
> (ent->flags & CE_TRIMAT)) &&
> +=09=09    check_time_rotate) {
>
thx for ur effort...
unfortunately i do not have any fbsd box currently...

but i did a lazy code inspection and think, that it looks ok...
but:
} else if ((ent->flags & CE_TRIMAT) && check_time_rotate) {
should suffice, since "check_time_rotate" cant become 1 if "ent->hours > 0"=
 or can it? not really sure... :)

-arne=0A=0A=0A