From owner-cvs-all Sat May 27 15:56:19 2000 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id 94DF037B8BF; Sat, 27 May 2000 15:56:12 -0700 (PDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.9.3/8.9.3) with ESMTP id QAA29658; Sat, 27 May 2000 16:56:10 -0600 (MDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id QAA01090; Sat, 27 May 2000 16:56:00 -0600 (MDT) Message-Id: <200005272256.QAA01090@harmony.village.org> To: obrien@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/aic7xxx Makefile Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Sat, 27 May 2000 15:05:42 PDT." <20000527150542.A1535@dragon.nuxi.com> References: <20000527150542.A1535@dragon.nuxi.com> <200005272135.OAA31512@freefall.freebsd.org> <200005272145.PAA00796@harmony.village.org> Date: Sat, 27 May 2000 16:56:00 -0600 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20000527150542.A1535@dragon.nuxi.com> "David O'Brien" writes: : On Sat, May 27, 2000 at 03:45:45PM -0600, Warner Losh wrote: : > Shouldn't we be using the same tests we use in bsd.kmod.mk and use : > ${SYSDIR}/sys/*.h rather than /sys/sys/*.h? The former either exists : : "-I../.." is acutally what is used. This makes ../../sys/param.h to be : used over /usr/include/sys/param.h. Is there a more appropiate path to : use instead? No. That's the right way. I should have looked at the patch first. Since this will only build in tree, this is the right way to fix it. I know in the past that we didn't do this because we had a time when the userland headers had to match the kernel headers for many critical definions and you got into more trouble than it was worth trying to mix the two like this. I think this was at the cut over from 2.x -> 3.x, but I'm not completely sure. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message