From owner-svn-src-head@freebsd.org Tue Feb 21 17:00:37 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2663FCE8394; Tue, 21 Feb 2017 17:00:37 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB71C1D88; Tue, 21 Feb 2017 17:00:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 1FD0B3C69; Tue, 21 Feb 2017 17:00:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id E94B030E48; Tue, 21 Feb 2017 17:00:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id mSHE1YD21SaA; Tue, 21 Feb 2017 17:00:10 +0000 (UTC) Subject: Re: svn commit: r313909 - head/sys/kern DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 7AEDB30E42 To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201702180507.v1I57rOM008704@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <9e48d2b2-5064-3293-e8e0-b4959f58507b@FreeBSD.org> Date: Tue, 21 Feb 2017 08:59:42 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <201702180507.v1I57rOM008704@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DGgnjOocaJGIdWiCv46cbsVgwiT7q5t8t" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2017 17:00:37 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DGgnjOocaJGIdWiCv46cbsVgwiT7q5t8t Content-Type: multipart/mixed; boundary="7k03QUvuRuMOUpr5ifn7kqWaP2Sg2mxkI"; protected-headers="v1" From: Bryan Drewery To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9e48d2b2-5064-3293-e8e0-b4959f58507b@FreeBSD.org> Subject: Re: svn commit: r313909 - head/sys/kern References: <201702180507.v1I57rOM008704@repo.freebsd.org> In-Reply-To: <201702180507.v1I57rOM008704@repo.freebsd.org> --7k03QUvuRuMOUpr5ifn7kqWaP2Sg2mxkI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2/17/2017 9:07 PM, Bryan Drewery wrote: > Author: bdrewery > Date: Sat Feb 18 05:07:53 2017 > New Revision: 313909 > URL: https://svnweb.freebsd.org/changeset/base/313909 >=20 > Log: > Fix panic with unlocked vnode to vrecycle(). > =20 > MFC after: 2 weeks >=20 > Modified: > head/sys/kern/uipc_mqueue.c >=20 > Modified: head/sys/kern/uipc_mqueue.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/uipc_mqueue.c Sat Feb 18 01:52:10 2017 (r313908) > +++ head/sys/kern/uipc_mqueue.c Sat Feb 18 05:07:53 2017 (r313909) > @@ -714,7 +714,9 @@ do_recycle(void *context, int pending __ > { > struct vnode *vp =3D (struct vnode *)context; > =20 > + vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); > vrecycle(vp); > + VOP_UNLOCK(vp, 0); > vdrop(vp); > } > =20 >=20 Just looking at this, it seemed questionable and most likely bitrotted. I added the lock to avoid an assertion to unblock me and allow the module to be used by others with INVARIANTS. Most of the vnode handling here is from the initial commit, long before a lot of refactoring around vnode lifecycle management. It does appear to need someone more familiar with vnode handling to go through and clean it up. --=20 Regards, Bryan Drewery --7k03QUvuRuMOUpr5ifn7kqWaP2Sg2mxkI-- --DGgnjOocaJGIdWiCv46cbsVgwiT7q5t8t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJYrHH+AAoJEDXXcbtuRpfPAn0H/iIm6+SBCboLL/G+5A0/8EBb 1hajAQ7RoXJoWYbeNy4XF2EaHUeWTAb/zCxj33l9AeVLTMRUdENCP9fU/YWdvtGZ 0vFB9fcphVJfRGoTq6reY7CUuwBTXItg+9onVV7ntC4s18e7zneSSyW1GTtC+Nt/ KOj0A6DkziphW1UHvMf1X+yapjU1Dc3QVZMKCIzWnRSCc1CN4rUPVZg0ZXsxJBhQ u7pxo6QygIvxNrODdqPPblDsGQJOLUINIhjw0GwT7KgKi4fMNJ4cNpKSXc48CUg9 1MS6OPc2so8uRTzCZ3PQNRHnbvD7eYzhWsg8DFrMNCfsTkXu4L6EB+i99aq4CXc= =yR4F -----END PGP SIGNATURE----- --DGgnjOocaJGIdWiCv46cbsVgwiT7q5t8t--