From owner-freebsd-bugs@FreeBSD.ORG  Tue Oct  2 21:30:12 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3992D1065676
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  2 Oct 2012 21:30:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 49E8E8FC1C
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  2 Oct 2012 21:30:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q92LUBSe027052
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 2 Oct 2012 21:30:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q92LUBJp027050;
	Tue, 2 Oct 2012 21:30:11 GMT (envelope-from gnats)
Resent-Date: Tue, 2 Oct 2012 21:30:11 GMT
Resent-Message-Id: <201210022130.q92LUBJp027050@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Erik Cederstrand <erik@cederstrand.dk>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B0C62106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue,  2 Oct 2012 21:21:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 9D13E8FC12
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue,  2 Oct 2012 21:21:58 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q92LLwXC018107
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 2 Oct 2012 21:21:58 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id q92LLwMn018106;
	Tue, 2 Oct 2012 21:21:58 GMT (envelope-from nobody)
Message-Id: <201210022121.q92LLwMn018106@red.freebsd.org>
Date: Tue, 2 Oct 2012 21:21:58 GMT
From: Erik Cederstrand <erik@cederstrand.dk>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: bin/172289: Check return value of setuid()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2012 21:30:12 -0000


>Number:         172289
>Category:       bin
>Synopsis:       Check return value of setuid()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 02 21:30:10 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Erik Cederstrand
>Release:        CURRENT
>Organization:
>Environment:
>Description:
When dropping root privileges, ping doesn't check the return value of setuid(). If setuid() fails, which it can do for a number of reasons, root privileges are not dropped. This is a privilege escalation.
>How-To-Repeat:

>Fix:
Check return value of setuid and abort if it fails.

Patch attached with submission follows:

Index: ping.c
===================================================================
--- ping.c	(revision 240960)
+++ ping.c	(working copy)
@@ -255,7 +255,8 @@
 	s = socket(AF_INET, SOCK_RAW, IPPROTO_ICMP);
 	sockerrno = errno;
 
-	setuid(getuid());
+	if (setuid(getuid()) != 0)
+        err(EX_NOPERM, "setuid() failed");
 	uid = getuid();
 
 	alarmtimeout = df = preload = tos = 0;


>Release-Note:
>Audit-Trail:
>Unformatted: