Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Dec 2001 16:04:44 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Kent Stewart <kstewart@owt.com>
Cc:        cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, =?ISO-8859-1?Q?S=F8ren?= Schmidt <sos@FreeBSD.ORG>
Subject:   Re: cvs commit: src/sys/dev/ata ata-dma.c ata-pci.c
Message-ID:  <XFMail.011216160444.jhb@FreeBSD.org>
In-Reply-To: <3C1C35D4.1070501@owt.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On 16-Dec-01 Kent Stewart wrote:
> 
> 
> Søren Schmidt wrote:
> 
>  > sos         2001/12/14 13:28:50 PST
>  >
>  >   Modified files:
>  >     sys/dev/ata          ata-dma.c ata-pci.c
>  >   Log:
>  >   Adjust the timings for the SiS chips a bit, also add the SiS 645.
>  >
>  >   Cosmetics on the Acer chips (print right modes)
>  >
>  >   Revision  Changes    Path
>  >   1.78      +9 -8      src/sys/dev/ata/ata-dma.c
>  >   1.22      +8 -5      src/sys/dev/ata/ata-pci.c
>  >
> 
> 
> Your change has a cosmetic error in the line in ata-dma.c. You have
> 
>               ata_find_dev(parent, 0x06451039, 0x00) ||   /* SiS 635 */
> 
> but the comment should be for a 745. The 745 chipset line is missing in
> the ata-pci.c module.

Eh? I submitted that cause I was testing on a SiS 645 chipset. :)  Perhaps you
need to add the 745 as well then in an additional line.  There is definitely a
645 chipset though, it is for Pentium 4 systems.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011216160444.jhb>