From owner-freebsd-ports-bugs@freebsd.org Tue Dec 15 13:18:43 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F0B98A44874 for ; Tue, 15 Dec 2015 13:18:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C7DEC1054 for ; Tue, 15 Dec 2015 13:18:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tBFDIhQ4082202 for ; Tue, 15 Dec 2015 13:18:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 205339] [PATCH] x11/kdelibs4: add options Date: Tue, 15 Dec 2015 13:18:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: matthew@reztek.cz X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kde@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 13:18:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205339 Bug ID: 205339 Summary: [PATCH] x11/kdelibs4: add options Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: kde@FreeBSD.org Reporter: matthew@reztek.cz Flags: maintainer-feedback?(kde@FreeBSD.org) Assignee: kde@FreeBSD.org Keywords: patch Created attachment 164267 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=164267&action=edit add options to x11/kdelibs4 x11/kdelibs4 has had a rather odd dependency and pkg-message for quite some time; it unconditionally depends on hupnp in order to build the UPnP backend for Solid, but there is also a patch which disables that backend, and the pkg-message notes it is known to cause instability and so is disabled but can be enabled via an environment variable. WTF?! Why build something just to leave it disabled, and if it's known to cause instability why is it being built at all? Restore some sanity to this port with a couple options: AVAHI and UPNP. The UPNP option replaces the hack with a normal option, which allows the patch and pkg-message to be removed. The AVAHI option simply makes that dependency optional since it is not required for KDE. The defaults of the new options are in keeping with past behavior, AVAHI is on as it was, UPNP is off because is is known unstable and the functionality was previously disabled. So, the only functional change is to drop a useless dependency by default. -- You are receiving this mail because: You are the assignee for the bug.