From owner-freebsd-current@FreeBSD.ORG Wed Jun 11 13:17:18 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3426937B401 for ; Wed, 11 Jun 2003 13:17:18 -0700 (PDT) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F78543FAF for ; Wed, 11 Jun 2003 13:17:17 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.12.9/8.12.9) with ESMTP id h5BKHECS032705; Wed, 11 Jun 2003 16:17:14 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <033701c3304f$c3a0a2a0$13fd2fd8@Admin02> References: <20030609210914.GA15553@nemesis.bsd-network.org><20030610194208.GA55855@ne mesis.bsd-network.org> <20030611.143132.74757193.haro@kgt.co.jp> <033701c3304f$c3a0a2a0$13fd2fd8@Admin02> Date: Wed, 11 Jun 2003 16:17:13 -0400 To: "Scot W. Hetzel" , "Munehiro Matsuda" From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.28 cc: current@freebsd.org cc: gordon@bsd-network.org Subject: Re: BDECFLAGS being added to CFLAGS and CWARNFLAGS ( was Re: [solved] buildworld error) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jun 2003 20:17:18 -0000 At 2:29 PM -0500 6/11/03, Scot W. Hetzel wrote: >From: "Munehiro Matsuda" > > I was having the same compile error, until I commeted out > > the BDECFLAGS definition from /etc/make.conf. > > > > Looking into the problematic Makefiles, I've found that > > following Makefiles do references BDECFLAGS, which matches > > errors I was getting: > > >> usr.sbin/config/Makefile : CFLAGS+= ${BDECFLAGS} >> usr.sbin/lpr/Makefile.inc: CWARNFLAGS= ${BDECFLAGS} >> usr.sbin/kgzip/Makefile : CFLAGS+= ${BDECFLAGS} >> > > I think these references must be removed. Ugh. Every time there's a scan for some bad-programming practice, 'lpr' is one of the guilty parties... I'll fix that one! >I did a find for BDECFLAGS and it found 5 Makefiles that >are adding these flags to either CFLAGS or CWARNFLAGS. > ># cd /usr/src ># find . -type f -exec grep -H "BDECFLAGS" {} + >./sbin/ffsinfo/Makefile:#CFLAGS+=${BDECFLAGS} >./sbin/growfs/Makefile:#CFLAGS+=${BDECFLAGS} >: >./usr.sbin/config/Makefile:CFLAGS+= ${BDECFLAGS} >./usr.sbin/lpr/Makefile.inc:CWARNFLAGS= ${BDECFLAGS} >./usr.sbin/kgzip/Makefile:CFLAGS+= ${BDECFLAGS} > >A couple of possible fixes are: > 1. removal of BDECFLAGS from the above files > 2. Add a .ifdef USE_BDECFLAGS .. .endif, that > conditionalizes the use of BDECFLAGS in the > above files. Ick. Then we'll need a "USE_USE_BDECFLAGS", to tell us if we should pay attention to the USE_BDECFLAGS variable... My guess is that there isn't a single reason that these five programs need to reference BDECFLAGS, especially now that it is no longer defined in /etc/defaults/make.conf . We should just remove those references. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu