From nobody Wed Apr 17 12:44:33 2024 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VKLGL53nDz5GqkT for ; Wed, 17 Apr 2024 12:44:58 +0000 (UTC) (envelope-from krzysztof.galazka@intel.com) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mgamail.intel.com", Issuer "Sectigo RSA Organization Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VKLGJ6J3fz4fNn for ; Wed, 17 Apr 2024 12:44:56 +0000 (UTC) (envelope-from krzysztof.galazka@intel.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=intel.com header.s=Intel header.b=K192qjBL; dmarc=pass (policy=none) header.from=intel.com; spf=pass (mx1.freebsd.org: domain of krzysztof.galazka@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=krzysztof.galazka@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713357897; x=1744893897; h=date:from:to:subject:message-id:mime-version; bh=nVo2aOHuFe+pWlvKrfFm/oaZrggDNZRhAuQ4QQMsKHE=; b=K192qjBLhhtBxF1mz4J2MUSMEkLc1iVY0oJCgPnPSlZ+HkPqopDFBr8B mUhBMW88t11vAJRVkLYBn1BQCQ2uJFa5ETBib1pltTmQtgtUkeiPY0OTf Ae8u0dAYXiQ9kfYqHfOs8q+FLtqMtC8V4dsJnwGvZI5iWFm+g/zXGd80m s4AVFglxyQ5a9G9zUQoypZMaH7LIdMT3AznD0Bdc3gg9ob1CHBQFNfpD4 jKuWiRLEOm4Mi6wV534uhPlDjs+JXROqjmgEAx+TY10qxs3tG60OYpE++ s6YzFPRuD0wFX4AumEKlrsZi7xfPQf+msLM9UC/E/KnIKmILMW14F3swp g==; X-CSE-ConnectionGUID: 2pzoRIvBTmmpAga5X0lnrw== X-CSE-MsgGUID: TZLb7stpTbyGypTaWvKqow== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="9397535" X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="9397535" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 05:44:54 -0700 X-CSE-ConnectionGUID: 8W+OF9koS36uEK843tuoeA== X-CSE-MsgGUID: uIIpxG8vQb2iseDu0CNXMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="27193758" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Apr 2024 05:44:54 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 17 Apr 2024 05:44:53 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 17 Apr 2024 05:44:53 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 17 Apr 2024 05:44:53 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 17 Apr 2024 05:44:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZQUEOxGo38nB+AA+mSdhnk3VwUaCEGznP/jJM6MT8YJ+4e52p7zjNMuy6he39ys6SExCs2g4wwB0t9uSJJ6lybKXt/+Q7hG1nwbCB8PzDTY55mItnu6f+4BP3/zxKdXvN1bcQ7LBhjwnfyNb+6r1v8LCIBGZC2jJ84ALAOvU3enKPQdsq+hu8EspW5H+ks1So1zMafRzCNzbbT8LFsafLP30ZV0GJ/RazumBawSirprdcau05kQUG56MBlBA+15/CrHgrOCYCuNnhs6McYl+JmMbwip8a7rPm4ltc6Bxw8p1YlV7I3PTldjcIx27CAAhOKuJ6GiGR0CwxQbE97ZFmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nVo2aOHuFe+pWlvKrfFm/oaZrggDNZRhAuQ4QQMsKHE=; b=HxQpaF+bo8L5F4VSUs3KH7VlN3sZEn8GW9tb3hYXfSz/oszVykyQC8pcLwg4iOOg6seT8QUGpAHYbDR8toMuoEvUPCBnz/hN3ZH99sRK/ld6a+M5q6ZOrnkvC0/O6AHYSIZxVln6l965/cVo9BfiynOGNzY///Lm3BPTSHIatOy8iMmDi0xWnzcGUM2nXjlM0KghN+iNwQL4lMbT2l7fH5tQaFuI/H4q8kZ990tdWCO2pqofFKjyxzNbvwYpjgnYTE1VBlbOeMgGMSQNBEnL6J+Zi2VQQ3fFc4RXQoSUm1NY0MUmK6Lvr2XrhMTzgKvBJrGGto0z2E9BlGAUwQ92YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB8268.namprd11.prod.outlook.com (2603:10b6:303:1ef::5) by CH0PR11MB5281.namprd11.prod.outlook.com (2603:10b6:610:bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.30; Wed, 17 Apr 2024 12:44:49 +0000 Received: from MW4PR11MB8268.namprd11.prod.outlook.com ([fe80::bb39:4224:2070:9739]) by MW4PR11MB8268.namprd11.prod.outlook.com ([fe80::bb39:4224:2070:9739%4]) with mapi id 15.20.7472.025; Wed, 17 Apr 2024 12:44:48 +0000 Date: Wed, 17 Apr 2024 14:44:33 +0200 From: Krzysztof Galazka To: Subject: [iflib] Allow concurrent execution of admin tasks from different interfaces Message-ID: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-ClientProxiedBy: DU2PR04CA0345.eurprd04.prod.outlook.com (2603:10a6:10:2b4::16) To MW4PR11MB8268.namprd11.prod.outlook.com (2603:10b6:303:1ef::5) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB8268:EE_|CH0PR11MB5281:EE_ X-MS-Office365-Filtering-Correlation-Id: f9eba6d2-61d1-4e38-ba95-08dc5edc2aee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dYCYq568QXTcuSCyNMvWb1bbA05I+6pjbhRlVnXJOYiJxsTilbgwg2gHIRltbP0f0FQA9jy/QG4YZiZ7ClWJIqk2RydjzBpYziR5WhOtgLrS7otXDcFqmnH31YfQPrHElr6yWEv/aqc9bLIEzMgcUxlwuj+OanEBDvC8idPiX15eZmSouY0W1xWDeD+OGVY+yUSm8/kmuI7K5LHkVWGLn7aTdBVFTv9imFPMvBuQltq6F1diVnxymfd/PEjpNBXp0wGlLlVj+OQ753OlQjpGrwvkOElJkumCrFJUTU16jK/lxe00W76sqBGkkUoBmx/nnuYfRGn59+qtLHoF0VXq9i48O4F0TangShh7uW685KGmYsoxHfqOofdxmdsrZejJDyNu6AchGrpkzmvyduzIU9D+rzTGb2Cq/O4gT3K6EzLz5l3yc4XAvQ1/tZd33mo4VcjjvJuzUNspWNiuzilXg8ESGTarMOAPUDvTg83pdqK+EnNANpD8+HVuk9ZjUT6UxB3R0QI1zzeyDdS7cQtx2uq5jSQInCJiGYY8Q/DLdSZ86oShh1EGmThsexpqXqKMYpZZTnPHlfgShFcD4D8xpj77dOqoJMRdglYu+fR7Fzn1P8FvIm4QUAUmKAIP8+QaLkLROMWkfoJyW770DlHFpw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB8268.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6/OX9MUmDOi0I1WaKcrrAs+ihwrrOdWOAQp4KcCANfZDYgsre75AnMquLT+J?= =?us-ascii?Q?bjtZ+7Ul9cxfzINY22rT4zPV5EYvOwImzsDw2JFHD64tNpLMGFTGj8MPCRKU?= =?us-ascii?Q?YlKwTKm4D21St/poWns5B2g5BcbN4CiE5RCAYospWDIiAFuhzmx1iY9VKmpw?= =?us-ascii?Q?rGiQPYpvQZrQMfC/QgQwRrUP4hup4dCU/ao5B/Ij4q2SK85YLffbMGLi0oFl?= =?us-ascii?Q?DzpfjwCn168Wy/wdyGHQE/cInXUFy0fHhjpA0GIo3ovAm4puQsMe6V4nKniG?= =?us-ascii?Q?/XJSZ7rO6SG/DisH0+Wvq5+Ys9V5KYxIdOYS0S8wPy2SWUTVySC1dk1PfJqm?= =?us-ascii?Q?6CxjpvWUkUtBRD1ytLoa1/yaZ5RuatlRwKeTf26Cxk/SBjJj71jaGAgzxX/3?= =?us-ascii?Q?BymMdketx2XE4z/8FzyBfS+ICxQw31XHx6W0xgJCKsDqesdWHCHD799JzsmB?= =?us-ascii?Q?5vhYD94LgPv+T9yJp6/7tz+ka2VQ+ImKiuGabQ8joICIFpg1fSltDAIgRILh?= =?us-ascii?Q?5K7lmRGcUGh9lfvQHg3CeDPjKc/6ghgFO5uICb7odkKdhxt0j74Ru3pr5843?= =?us-ascii?Q?RlbaxKH/KHvhWlO1qMF6FV2cMuIiGPlHXNHDLkcTcQP5Siz5U0r4mFOC05xB?= =?us-ascii?Q?IOTJp+ciT5KXFbfiRF4Jrnv3jQtk4gy5OOd+OLrHPp/ObkaWV4Qg9sRFRE9/?= =?us-ascii?Q?nSidQdDaF4jdaodTOF2l1Z9ZlUitMkiz0F1Uz4ebGCnb4UV2H24lGTtcBUD5?= =?us-ascii?Q?Npo6B4pVG9BOWAgiHWOOZXLkhaz2x2rWmnWGhYUHmRSDHb7IyCwRuWY9JNYY?= =?us-ascii?Q?bKJjDFVKnsjFHtIAmBTwwEddkJlGHd0q3FSJAzBJJjSZcmxQrzfPHypSDBJc?= =?us-ascii?Q?JnM6gpJBi4Uxx7iJbVQupLSDPR+zK3GwrcYEejEGX3EOaKDt4AZcPsn3XIt/?= =?us-ascii?Q?xj8MGvL4Im45sNIUpFRPdp/ELcOkNbaOPLvPjugHzXu/HdDjr+F6EBRoS3C0?= =?us-ascii?Q?4x4G0GIDZzWlol47iuC470mktCSvTJStRJ+lTxiFehI5BiwuLZC+IahBSyp8?= =?us-ascii?Q?yjnjmIIDyliFQAR3C/KbNpz6utS50yHdfHySIYtLPqcVzAASmxs7zEREMDQh?= =?us-ascii?Q?ZMbfRBI4+r/KUWwQlEvpoVcTN6fvk1/A+cefLuG3x/B1tTbuv+HOU6RYcmW6?= =?us-ascii?Q?X31nln7qQds5HEYC3y2nQ28e7X4EwVeAq8J5oQ/pXgd1kg0fEstxUQoOLxT2?= =?us-ascii?Q?yPC4xv4hOMre8UfSCpR52V9QbNzWS/8I7bJRXR6S16RiMj9iXV4HiBjZXgr+?= =?us-ascii?Q?JT96eX0ee+jIR8G+Aikzu1arrIdHgygoaSDAe3EpmBJSXiKEL/vlDDIku/Zd?= =?us-ascii?Q?nolIN+HaWYPyfSrc57AiXKUD3ffDdxAADpknWAMvReLQbe7hRM/E4HGCgqey?= =?us-ascii?Q?k2gGhruAM1HNIuurfGs3+b3OtC2jGQltkzTmzZCoBJWrsMUo7tfHpw1Qu1+a?= =?us-ascii?Q?0lhF2SIIh4T7wdfk7w/bXH7Q/1iYhrj+GNfZO8H8sJ3a4T6K1sZqbEa0ODlW?= =?us-ascii?Q?kw7ZB/cCw60HO3atdzp96tQ/oLoAGtLWlFW8KEKhqzNE2iTAxfI9u8Vkedis?= =?us-ascii?Q?Ug=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f9eba6d2-61d1-4e38-ba95-08dc5edc2aee X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB8268.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 12:44:48.6699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XipTl9a+k2jU51geVtYJYCWQTiIncs+SgdZewlJNIR+xb2GUeTDIKGpycqCPIdUQZlLeiKEcZ9LkdV7UQXnd0Joe+L847HzdNUeADjVTFGA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5281 X-OriginatorOrg: intel.com X-Spamd-Bar: ------- X-Spamd-Result: default: False [-7.10 / 15.00]; WHITELIST_SPF_DKIM(-3.00)[intel.com:d:+,intel.com:s:+]; NEURAL_HAM_LONG(-1.00)[-1.000]; ARC_REJECT(1.00)[signature check failed: fail, {[1] = sig:microsoft.com:reject}]; DWL_DNSWL_LOW(-1.00)[intel.com:dkim]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[intel.com,none]; R_DKIM_ALLOW(-0.20)[intel.com:s=Intel]; R_SPF_ALLOW(-0.20)[+ip4:192.198.163.0/26]; RCVD_IN_DNSWL_LOW(-0.10)[192.198.163.16:from]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_NONE(0.00)[104.47.70.101:received]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:4983, ipnet:192.198.162.0/23, country:US]; RCVD_COUNT_SEVEN(0.00)[8]; MLMMJ_DEST(0.00)[freebsd-net@freebsd.org]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[intel.com:+] X-Rspamd-Queue-Id: 4VKLGJ6J3fz4fNn Hi, In current iflib implementation there is a single task queue group used for all admin tasks, defined with: iflib.c:560 TASKQGROUP_DEFINE(if_config_tqg, 1, 1); This does not allow for concurrent processing of tasks. In systems with a large number of interfaces this may cause one long running task (e.g. related to FW update) to trigger timeouts of other tasks. Changing that to: TASKQGROUP_DEFINE(if_config_tqg, mp_cpu, 1); works, but might be an overkill. I don't see a way to dynamically add new threads/cpus to already defined taskqgroup though. I'll be grateful for any suggestions how to approach this issue. Thanks, Krzysiek