From owner-freebsd-ports Thu Apr 6 06:53:51 1995 Return-Path: ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA27019 for ports-outgoing; Thu, 6 Apr 1995 06:53:51 -0700 Received: from palmer.demon.co.uk (root@palmer.demon.co.uk [158.152.50.150]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id GAA27011 for ; Thu, 6 Apr 1995 06:53:41 -0700 Received: from localhost (localhost [127.0.0.1]) by palmer.demon.co.uk (8.6.11/8.6.11) with SMTP id OAA01065 ; Thu, 6 Apr 1995 14:30:37 +0100 X-Authentication-Warning: palmer.demon.co.uk: Host localhost didn't use HELO protocol To: Chuck Bacon cc: ports@FreeBSD.org Subject: Re: Error in GUIDELINES In-reply-to: Your message of "Thu, 06 Apr 1995 08:10:09 EDT." <199504061210.IAA02118@upcoming.dcrt.nih.gov> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1061.797175036.1@palmer.demon.co.uk> Date: Thu, 06 Apr 1995 14:30:37 +0100 Message-ID: <1062.797175037@palmer.demon.co.uk> From: Gary Palmer Sender: ports-owner@FreeBSD.org Precedence: bulk In message <199504061210.IAA02118@upcoming.dcrt.nih.gov>, Chuck Bacon writes: > #ifdef _HAVE_PARAM_H > #include > #endif >which is wrong. The conditional is backward; it should be #ifndef. Huh. The _HAVE_PARAM_H is meant to be set in a Makefile somewhere to indicate that we do infact have the sys/param.h header file. #ifndef _HAVE_PARAM_H would be stupid, and I actually think I know what you're thinking of here. More in a tick. >Furthermore the conditional should be omitted, since the same >conditional surrounds the entirety of . Bzzzt. Nope. Wrong. The contitional in is : #ifndef _SYS_PARAM_H_ and is to stop warnings/errors due to repeated inclusion of the file. The point of the _HAVE_PARAM_H variable is that not every machine does have a . Why they'd be compiling a FreeBSD port on it is beyond reasoning, but there you go! Gary