From owner-freebsd-ports-bugs@freebsd.org Fri Aug 28 02:15:27 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79BFF9C344E for ; Fri, 28 Aug 2015 02:15:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BB90DD0 for ; Fri, 28 Aug 2015 02:15:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t7S2FRvl083560 for ; Fri, 28 Aug 2015 02:15:27 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 200015] [New port] dns/dnscrypt-wrapper Date: Fri, 28 Aug 2015 02:15:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: junovitch@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: junovitch@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete cc assigned_to bug_status attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2015 02:15:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200015 Jason Unovitch changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157996|0 |1 is obsolete| | CC| |junovitch@freebsd.org Assignee|freebsd-ports-bugs@FreeBSD. |junovitch@freebsd.org |org | Status|New |In Progress --- Comment #3 from Jason Unovitch --- Created attachment 160429 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=160429&action=edit Revised Shar Hello, I've attached a revision and I have some questions. First off, let's not commit an old version to start off. 0.2 was released at the start of the month. Fortunately this solves the issue regarding the separate argparse so drop that Makefile code. Formatting: - standardize indentation in Makefile - wrap pkg-descr at 80 lines - add a '/' to the end of the WWW for a proper URL Content: - Don't set PORTREVISION= 1 for a brand new port - Use %%USERS%% in the rc.d script - Also use %%ETCDNSCRYPTWRAPPER%% variables rather than /var/log/dnscrypt-wrapper.log in multiple places in the rc.d script - Remove the crypt public key lines, per 0.2 release notes: "Crypt public key is not required, see README.md for detail instructions." Questions: 1. Is the umask 007 for the keys correct? What use does the wheel group have for needing read access to the keys? 2. How did you test it at runtime? It's just hanging when I do the drill shown on the authors github. Any feedback would be appreciated. -- You are receiving this mail because: You are the assignee for the bug.