From owner-freebsd-ports@FreeBSD.ORG Sun Feb 21 12:24:19 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 415E01065694 for ; Sun, 21 Feb 2010 12:24:19 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.50.215]) by mx1.freebsd.org (Postfix) with ESMTP id 1A5D68FC0C for ; Sun, 21 Feb 2010 12:24:18 +0000 (UTC) Received: by syn.atarininja.org (Postfix, from userid 1001) id 42F095C3D; Sun, 21 Feb 2010 07:24:18 -0500 (EST) Date: Sun, 21 Feb 2010 07:24:18 -0500 From: Wesley Shields To: Dominic Fandrey Message-ID: <20100221122418.GA94133@atarininja.org> References: <4B80EAD4.1070109@bsdforen.de> <4B81006D.2000906@bsdforen.de> <4B81049A.8060400@bsdforen.de> <4B81129E.5040401@bsdforen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B81129E.5040401@bsdforen.de> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Christer Solskogen , ports@freebsd.org Subject: Re: make package-noinstall does not include rc.d scripts? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Feb 2010 12:24:19 -0000 On Sun, Feb 21, 2010 at 12:01:50PM +0100, Dominic Fandrey wrote: > On 21/02/2010 11:02, Dominic Fandrey wrote: > > On 21/02/2010 10:47, Christer Solskogen wrote: > >> On Sun, Feb 21, 2010 at 10:44 AM, Dominic Fandrey wrote: > >> > >>> So the right solution might be for the "package-noinstall" target to > >>> use "pkg_create -b" and additionally create the symlinks. > >>> > >>> I do not like have different code for doing the same thing in this > >>> context. > >> > >> Does the target 'package' use pkg_create? > > > > Yes it does. > > More precisely, do-package does. > > > I have a patch that should do the trick. Would you be so kind to test > > it? > > http://www.home.hs-karlsruhe.de/~fado0001/patch-ports-Mk-bsd.port.mk.txt > > > > If it does, please open a PR and post the number here. wxs and I can > > post our patches there and portmgr can decide. > > After testing my patch to my satisfaction I went ahead and opened a PR: > http://www.freebsd.org/cgi/query-pr.cgi?pr=144164 No need for my patch to make it into the PR. I like your solution better. ;) -- WXS