From owner-freebsd-bugs@FreeBSD.ORG Mon Jan 20 18:40:02 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 90F72F50 for ; Mon, 20 Jan 2014 18:40:02 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7063B1DBC for ; Mon, 20 Jan 2014 18:40:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s0KIe2dN005245 for ; Mon, 20 Jan 2014 18:40:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s0KIe28l005244; Mon, 20 Jan 2014 18:40:02 GMT (envelope-from gnats) Date: Mon, 20 Jan 2014 18:40:02 GMT Message-Id: <201401201840.s0KIe28l005244@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Garrett Cooper Subject: Re: misc/181151: builtins/locale1.0 fails X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Garrett Cooper List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jan 2014 18:40:02 -0000 The following reply was made to PR misc/181151; it has been noted by GNATS. From: Garrett Cooper To: Jilles Tjoelker Cc: bug-followup@FreeBSD.org, Julio Merino Subject: Re: misc/181151: builtins/locale1.0 fails Date: Mon, 20 Jan 2014 10:37:40 -0800 On Jan 19, 2014, at 5:27 AM, Jilles Tjoelker wrote: > On Fri, Jan 17, 2014 at 11:05:28PM -0800, Garrett Cooper wrote: >> On Aug 9, 2013, at 6:06 AM, Jilles Tjoelker wrote: >=20 >>> In PR misc/181151, you wrote: >>>> [sh test builtins/locale1.0 fails] >=20 >>> I think you have disabled some parts of locale support, since it = works >>> fine here. The test uses nl_NL.ISO8859-1 as its non-English locale. >=20 >> What exactly do I need in order to make this test pass? It=92s the = one >> test that=92s not passing on my CURRENT VM now.. >=20 > You can debug by running the test manually. =46rom bin/sh/tests/, run > SH=3Dsh sh builtins/locale1.0 > or > SH=3Dsh sh -x builtins/locale1.0 > and look at what it does not like. Ok, some issues. 1. I set SH to /usr/local/bin/bash in .shrc-local, so that=92s not going = to work with the tests out of the box. The tests need to unset/use a = different variable name other than ${SH} IMHO as it=92s a standard shell = variable. 2. Checking for /var/empty/foo might not be such a great idea. Why not = create a temporary file, then delete it? 3. Other than that, the locale tests don=92t seem to be working as = expected (it=92s acting like LANG=3DC =97 output=92s available below). Thanks! -Garrett # /bin/sh -x builtins/locale1.0=20 + failures=3D0 + unset LANG LC_ALL LC_COLLATE LC_CTYPE LC_MONETARY LC_NUMERIC LC_TIME = LC_MESSAGES + unset LANGUAGE + msgeng=3D'No such file or directory' + msgdut=3D'Bestand of map niet gevonden' + command . /var/empty/foo + ok=3D1 + check '$ok -eq 1' 24 + eval '[ $ok -eq 1 ]' + [ 1 -eq 1 ] + LC_ALL=3DC command . /var/empty/foo + ok=3D1 + check '$ok -eq 1' 31 + eval '[ $ok -eq 1 ]' + [ 1 -eq 1 ] + LC_ALL=3DC LANG=3Dnl_NL.ISO8859-1 command . /var/empty/foo + ok=3D1 + check '$ok -eq 1' 37 + eval '[ $ok -eq 1 ]' + [ 1 -eq 1 ] + LC_ALL=3DC LC_MESSAGES=3Dnl_NL.ISO8859-1 command . /var/empty/foo + ok=3D1 + check '$ok -eq 1' 43 + eval '[ $ok -eq 1 ]' + [ 1 -eq 1 ] + LC_CTYPE=3Dnl_NL.ISO8859-1 command . /var/empty/foo + ok=3D1 + check '$ok -eq 1' 49 + eval '[ $ok -eq 1 ]' + [ 1 -eq 1 ] + export LANG=3Dnl_NL.ISO8859-1 + command . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 56 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 56' Failed: $ok -eq 1 at 56 + : 1 + export LC_MESSAGES=3Dnl_NL.ISO8859-1 + command . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 62 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 62' Failed: $ok -eq 1 at 62 + : 2 + export LC_ALL=3Dnl_NL.ISO8859-1 + command . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 68 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 68' Failed: $ok -eq 1 at 68 + : 3 + LANG=3Dnl_NL.ISO8859-1 command . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 74 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 74' Failed: $ok -eq 1 at 74 + : 4 + LC_MESSAGES=3Dnl_NL.ISO8859-1 command . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 80 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 80' Failed: $ok -eq 1 at 80 + : 5 + LC_ALL=3Dnl_NL.ISO8859-1 command . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 86 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 86' Failed: $ok -eq 1 at 86 + : 6 + command . /var/empty/foo + ok=3D1 + check '$ok -eq 1' 93 + eval '[ $ok -eq 1 ]' + [ 1 -eq 1 ] + LANG=3Dnl_NL.ISO8859-1 command . /var/empty/foo + command . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 99 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 99' Failed: $ok -eq 1 at 99 + : 7 + LC_MESSAGES=3Dnl_NL.ISO8859-1 command . /var/empty/foo + command . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 105 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 105' Failed: $ok -eq 1 at 105 + : 8 + LC_ALL=3Dnl_NL.ISO8859-1 command . /var/empty/foo + command . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 111 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 111' Failed: $ok -eq 1 at 111 + : 9 + LC_ALL=3Dnl_NL.ISO8859-1 . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 118 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 118' Failed: $ok -eq 1 at 118 + : 10 + LC_ALL=3Dnl_NL.ISO8859-1 . /dev/null + . /var/empty/foo + ok=3D1 + check '$ok -eq 1' 126 + eval '[ $ok -eq 1 ]' + [ 1 -eq 1 ] + export LC_ALL + LC_ALL=3Dnl_NL.ISO8859-1 . /dev/null + . /var/empty/foo + ok=3D0 + check '$ok -eq 1' 132 + eval '[ $ok -eq 1 ]' + [ 0 -eq 1 ] + echo 'Failed: $ok -eq 1 at 132' Failed: $ok -eq 1 at 132 + : 11 + exit 1 # env LC_CTYPE=3Dnl_NL.ISO8859-1 /bin/sh -c 'command . /var/empty/foo' .: cannot open /var/empty/foo: No such file or directory=