From owner-cvs-all Wed Aug 15 16:42:28 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.wrs.com (unknown-1-11.windriver.com [147.11.1.11]) by hub.freebsd.org (Postfix) with ESMTP id 3F9F637B401; Wed, 15 Aug 2001 16:42:19 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@[147.11.46.201]) by mail.wrs.com (8.9.3/8.9.1) with ESMTP id QAA13640; Wed, 15 Aug 2001 16:42:18 -0700 (PDT) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010815230049.B717-100000@heather.plazza.uk> Date: Wed, 15 Aug 2001 16:42:23 -0700 (PDT) From: John Baldwin To: Nick Hibma Subject: Re: cvs commit: src/sys/pci ohci_pci.c uhci_pci.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Nick Sayer Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 15-Aug-01 Nick Hibma wrote: > > I'd appreciated a heads up on this. There are issues with this change, > which prevent some laptops to go haywire, interrupt storms. This was > discussed with John Baldwin and some other people, but no resolution so > far. > > If people are willing to take the risk of failing to be able to install > on some laptops then this change is fine with me. The other option is to > back this out and end up with some laptops that won't be able to use > USB. We already couldn't install 4.3 on said laptops (Compaq Armadas) so it can't really make things any worse. :-/ The laptops in question had a real lame BIOS that didn't let you set any options (including PnP OS). FWIW, Linux had similar issues as well IIRC. > Nick > > > > On Wed, 15 Aug 2001, Nick Sayer wrote: > >> nsayer 2001/08/15 10:03:08 PDT >> >> Modified files: (Branch: RELENG_4) >> sys/pci ohci_pci.c uhci_pci.c >> Log: >> MFC: Now that PCI IRQ routing has come to RELENG_4, USB controllers >> should no longer attempt to bomb out if their initial IRQ setting is >> invalid. The PCI IRQ routing code will fix it. >> >> Reviewed by: imp >> Approved by: re >> >> Revision Changes Path >> 1.16.2.3 +1 -12 src/sys/pci/ohci_pci.c >> 1.26.2.4 +1 -12 src/sys/pci/uhci_pci.c >> >> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/pci/ohci_pci.c?r1=1.16.2.2&r2 >> =1.16.2.3&cvsroot=freebsd >> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/pci/uhci_pci.c?r1=1.26.2.3&r2 >> =1.26.2.4&cvsroot=freebsd >> > -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message