From owner-freebsd-apache@FreeBSD.ORG Sun Aug 12 22:26:32 2012 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F6C9106564A for ; Sun, 12 Aug 2012 22:26:32 +0000 (UTC) (envelope-from pgollucci@p6m7g8.com) Received: from mail-qa0-f47.google.com (mail-qa0-f47.google.com [209.85.216.47]) by mx1.freebsd.org (Postfix) with ESMTP id C65B18FC17 for ; Sun, 12 Aug 2012 22:26:31 +0000 (UTC) Received: by qadc11 with SMTP id c11so583941qad.13 for ; Sun, 12 Aug 2012 15:26:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:content-type:x-gm-message-state; bh=eFFWjcYUJfZ8gtMnNhXh/lGBK7HzgD8QgqQuuSNC6tI=; b=KWjCRyShB2b+8ZkBuby/EKigp9PNCuknFsJUcKSU52AZCvLB7fd4UVYqagnif+8kuO hWTg/2FzaXFAaGN9gLvP/0cuCo13pyemS3TO/ADKlfGfIO52KdmGLrJW0h3dHoGZi97C L8bc24jdvrwY7iYLhE1t8GM/bUFDoFJbKTLb+gr1SaehUHv+q2xq0y9ihgUg/5fu4C6g r+WxfZbqiis8krQFQgtCSMxV40Ax/2cMn3FFP6yf6F9SGHACpyGNMdq+rj4tavKy9ZWg kcNf86HBHRbelD7pY2HPFNzsq/P8GWcL7NEqoNm7faY76+QLSJeNeNZBQR0bg6um6Q5f 167w== MIME-Version: 1.0 Received: by 10.224.177.5 with SMTP id bg5mr21260091qab.40.1344810390457; Sun, 12 Aug 2012 15:26:30 -0700 (PDT) Received: by 10.49.85.41 with HTTP; Sun, 12 Aug 2012 15:26:30 -0700 (PDT) X-Originating-IP: [64.134.66.62] In-Reply-To: <50282839.6060800@FreeBSD.org> References: <50282839.6060800@FreeBSD.org> Date: Sun, 12 Aug 2012 18:26:30 -0400 Message-ID: From: "Philip M. Gollucci" To: "apache@FreeBSD.org" X-Gm-Message-State: ALoCoQki2IXxlEqMOkA2TxUGCiQg4xmhGwnMjd8gOJL5svJkAgxu3yF/20ZXtsXW+OHClKYrWIMn Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: bsd.apache.mk rewrite / cleanup X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2012 22:26:32 -0000 Looks fine to me. Why don't we just act on removing www/apache20 and devel/apr0. Then committing this is simpler Then making www/apache24 is easier Then moving APACHE_PORT to www/apache24 is 'easier' minus the MPM change. On Sun, Aug 12, 2012 at 6:03 PM, Olli Hauer wrote: > Hi all, > > the bsd.apache.mk script has undergone a rewrite for better support of > options NG. > > changed: > - make.conf pa-rams like WITH(OUT)_MODULES should be given in UPPER case. > Code to convert make.conf pa-rams to UPPER case is in place > - cleanup old constructs which are working in a sub-shell (@for ... > ${GREP} ...) > the parts are replaced to use make logic. > - adjust apache20/apache22 ports for the new bsd.apache.mk. > > The bsd.apache.mk file should be touched again to support options NG in > apache2x > but those changes are only a view lines. > > I want to keep make.conf support the same way it works now even if apache22 > is rewritten with options NG support. This means against new options NG > logic > the make.conf has priority over options set by "make config" (old > behavior). > To give make.conf and command line pa-rams a higher priority is needed for > static and other special builds. > > I've done endless tests with the rewritten bsd.apache.mk and have not > found any > backward incompatible issues (except if we remove the UPPERCASE convert > part) > > There is additional room for more cleanup, some comments are in the patch > (MFC TODO). > > For anyone interested in review before I commit the patches > > http://people.freebsd.org/~ohauer/diffs/apache/bsd.apache.mk_rewrite_2012-08-12.txt > > -- > olli > _______________________________________________ > freebsd-apache@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-apache > To unsubscribe, send any mail to "freebsd-apache-unsubscribe@freebsd.org" > -- --------------------------------------------------------------------------------------------- 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Director Operations, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching.