Date: Fri, 1 Jun 2001 18:00:03 -0700 (PDT) From: Glenn Trewitt <glenn@trewitt.org> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/24136: sysinstall's install.cfg tryRTSOL and tryDHCP don't work Message-ID: <200106020100.f52103M69348@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/24136; it has been noted by GNATS. From: Glenn Trewitt <glenn@trewitt.org> To: freebsd-gnats-submit@FreeBSD.org, gordont@bluemtn.net Cc: Subject: Re: bin/24136: sysinstall's install.cfg tryRTSOL and tryDHCP don't work Date: Fri, 01 Jun 2001 17:51:57 -0700 I just ran across the same bug. I think that I found the more basic problem. In tcpip.c, the code that tests the value of tryDHCP (and tryRTSOL) has the test backwards when checking for the "NO" value. In the code: if (!variable_cmp(VAR_TRY_DHCP, "YES") || ((!variable_cmp(VAR_TRY_DHCP, "NO")) && (!msgNoYes("Do you want to try DHCP configuration of the interface?")))) { should be if (!variable_cmp(VAR_TRY_DHCP, "YES") || ((variable_cmp(VAR_TRY_DHCP, "NO")) && (!msgNoYes("Do you want to try DHCP configuration of the interface?")))) { I think that this addresses the underlying problem. (This also explains why setting tryDHCP to anything besides "YES" or "NO" has the effect expected for tryDHCP=NO. - Glenn Trewitt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106020100.f52103M69348>