From owner-freebsd-stable Fri Jan 11 16:18:25 2002 Delivered-To: freebsd-stable@freebsd.org Received: from dastardly.newsbastards.org.72.27.172.IN-addr.ARPA.NetScum.dyndns.dk (pop-mu-11-2-dialup-152.freesurf.ch [194.230.150.152]) by hub.freebsd.org (Postfix) with ESMTP id 0B66E37B41C for ; Fri, 11 Jan 2002 16:17:48 -0800 (PST) Received: from beerswilling.netscum.dyndns.dk (dcf77-zeit.netscum.dyndns.dk [172.27.72.27] (may be forged)) by dastardly.newsbastards.org.72.27.172.IN-addr.ARPA.NetScum.dyndns.dk (8.11.6/8.11.6) with ESMTP id g0C06sR00194 (using TLSv1/SSLv3 with cipher EDH-RSA-DES-CBC3-SHA (168 bits) verified FAIL) for ; Sat, 12 Jan 2002 01:06:55 +0100 (CET) (envelope-from bounce@dcf77-zeit.netscum.dyndns.dk) Received: (from root@localhost) by beerswilling.netscum.dyndns.dk (8.11.6/8.11.6) id g0C06s800193; Sat, 12 Jan 2002 01:06:54 +0100 (CET) (envelope-from bounce@dcf77-zeit.netscum.dyndns.dk) Date: Sat, 12 Jan 2002 01:06:54 +0100 (CET) Message-Id: <200201120006.g0C06s800193@beerswilling.netscum.dyndns.dk> From: BOUWSMA Beery Subject: Two trivial problems in 4.5-RC, with untested patches To: freebsd-stable@freebsd.org Organization: Men not wearing any pants that dont shave X-Hacked: via telnet to your port 25, what else? X-Internet-Access-Provided-By: TDC Suisse AG, Rumlang X-NetScum: Yes X-One-And-Only-Real-True-Fluffy: No Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG [replies sent directly to me may timeout and bounce, since I'm not online as often as I should be, but I'll check the list archives] Hejsa I've made mention of these two things before thinking about them. Now I think I know what's going on, and offer suggestions about what to do about them. 1) mount_mfs a /tmp filesysyem: Warning: Block size and bytes per inode restrict cylinders per group to 22. Why not quiet the warning in this case, with the following *untested* patch? --- /FreeBSD-4/usr/local/system/src/sbin/newfs/mkfs.c Wed Oct 31 21:44:35 2001 +++ /FreeBSD-4/usr/local/source-hacks/sbin/newfs/mkfs.c Fri Jan 11 23:02:45 2002 @@ -499,7 +499,7 @@ printf("cylinder groups must have at least %ld cylinders\n", mincpg); exit(25); - } else if (sblock.fs_cpg != cpg) { + } else if (!mfs && sblock.fs_cpg != cpg) { if (!cpgflg) printf("Warning: "); else if (!mapcramped && !inodecramped) The (mfs) test is used elsewhere to determine whether to spit out warnings or not. I don't know if mapcramped and inodecramped or anything else would make a difference, in which case the mfs test could be moved within the `if {' to allow the various exit()s to be reached. 2) umount -a -v -t xxxfs umount: cd9660: unknown mount type This happens when a `noauto' mount is specified in /etc/fstab in this day of filesystem kernel modules, when the given filesysyem has never been loaded. You don't see this with static filesystems built into the kernel, but who does that nowadays? I'm not sure what purpose such a check serves today except to cause bogglement in cases like the above. This *untested* patch --- /FreeBSD-4/usr/local/system/src/sbin/umount/umount.c Thu Dec 13 21:40:48 2001 +++ /FreeBSD-4/usr/local/source-hacks/sbin/umount/umount.c Fri Jan 11 23:37:04 2002 @@ -212,11 +212,17 @@ strcmp(fs->fs_type, FSTAB_RO) && strcmp(fs->fs_type, FSTAB_RQ)) continue; +#if 0 +/* XXXX In these days of loadable kernel filesystem modules, you + can't make this simple check. If anything, one should check + for presence of a mount_xxxfs executable as in mount/mount.c + but for now, that's more hacking than I feel like doing */ /* If an unknown file system type, complain. */ if (getvfsbyname(fs->fs_vfstype, &vfc) == -1) { warnx("%s: unknown mount type", fs->fs_vfstype); continue; } +#endif if (checkvfsname(fs->fs_vfstype, typelist)) continue; is intended to skip this check until a better solution is found. I don't expect these hac^H^H^Hpatches to be used. Unless they are the right idea. thanks barry bouwsma To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message