From owner-cvs-all Tue Mar 6 14:22:14 2001 Delivered-To: cvs-all@freebsd.org Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by hub.freebsd.org (Postfix) with ESMTP id 5950737B718; Tue, 6 Mar 2001 14:22:06 -0800 (PST) (envelope-from gibbs@scsiguy.com) Received: from scsiguy.com (localhost [127.0.0.1]) by aslan.scsiguy.com (8.11.2/8.9.3) with ESMTP id f26MM0O09064; Tue, 6 Mar 2001 15:22:05 -0700 (MST) (envelope-from gibbs@scsiguy.com) Message-Id: <200103062222.f26MM0O09064@aslan.scsiguy.com> To: John Baldwin Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_intr.c src/sys/sys interrupt.h In-Reply-To: Your message of "Tue, 06 Mar 2001 13:38:51 PST." Date: Tue, 06 Mar 2001 15:22:00 -0700 From: "Justin T. Gibbs" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >> I haven't tested this either, but it should work. We should also update >> the manual page to indicate that you must deregister from a context >> that can sleep. In SMPNG, there should be very few places where you >> can't sleep. > >Right now interrupt handlers and any place holding a mutex are the only places >where sleeping is bad. Are you referring to bus_teardown_intr(9)? Yes. >> Unecessary locks are, unecessary. > >Well, there's a lot of extra hacking in here to make it unnecessary. Using a >lock would simplify the code immensely and make future maintenance easier. It seems like a pretty standard scheme used for lock free list manipulation. Interrupts happen a lot, so they should be optimized. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message