From owner-freebsd-bugs@FreeBSD.ORG Sun Aug 8 19:10:07 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC2BF16A4CE for ; Sun, 8 Aug 2004 19:10:07 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A85C143D4C for ; Sun, 8 Aug 2004 19:10:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i78JA7Zf010695 for ; Sun, 8 Aug 2004 19:10:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i78JA7sU010692; Sun, 8 Aug 2004 19:10:07 GMT (envelope-from gnats) Resent-Date: Sun, 8 Aug 2004 19:10:07 GMT Resent-Message-Id: <200408081910.i78JA7sU010692@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, coolaz@web.de Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 963E716A4CE for ; Sun, 8 Aug 2004 19:04:15 +0000 (GMT) Received: from smtp05.web.de (smtp05.web.de [217.72.192.209]) by mx1.FreeBSD.org (Postfix) with ESMTP id 627AE43D5F for ; Sun, 8 Aug 2004 19:04:15 +0000 (GMT) (envelope-from coolaz@web.de) Received: from [145.254.34.127] (helo=thunderBSD.tld) by smtp05.web.de with asmtp (TLSv1:DES-CBC3-SHA:168) (WEB.DE 4.101 #44) id 1Btsxp-00058u-00; Sun, 08 Aug 2004 21:04:14 +0200 Received: from thunderBSD.tld (localhost [127.0.0.1]) by thunderBSD.tld (8.12.11/8.12.11) with ESMTP id i78J7dUW000887; Sun, 8 Aug 2004 21:07:40 +0200 (CEST) (envelope-from martin@thunderBSD.tld) Received: (from martin@localhost) by thunderBSD.tld (8.12.11/8.12.11/Submit) id i78IivOs000684; Sun, 8 Aug 2004 20:44:57 +0200 (CEST) (envelope-from martin) Message-Id: <200408081844.i78IivOs000684@thunderBSD.tld> Date: Sun, 8 Aug 2004 20:44:57 +0200 (CEST) From: Martin Kulas Sender: coolaz@web.de To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: localtux@yahoo.de Subject: bin/70182: [patch] fortune -e implementation bug X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: coolaz@web.de List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2004 19:10:07 -0000 >Number: 70182 >Category: bin >Synopsis: [patch] fortune -e implementation bug >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 08 19:10:07 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Martin Kulas >Release: FreeBSD 4.10-RELEASE i386 >Organization: None >Environment: System: FreeBSD 4.10-RELEASE FreeBSD 4.10-RELEASE #0: Sat Jun 19 23:12:40 CEST 2004 i386 >Description: If I type ``fortune -e murphy startrek'' several times, ich will get only messages from ``murphy'' but not from ``startrek''. If I understand the ``-e'' flag correctly, this flag should treat all fortune files equally. >How-To-Repeat: Just type ``fortune -e murphy startrek'' and you will not get any message from ``startrek''. >Fix: Apply the following patch: --- fortune.c.orig Fri Aug 6 15:13:28 2004 +++ fortune.c Sun Aug 8 00:51:38 2004 @@ -933,7 +933,7 @@ if (num_noprob > 1) { frac = percent / num_noprob; DPRINTF(1, (stderr, ", frac = %d%%", frac)); - for (fp = File_list; fp != last; fp = fp->next) + for (fp = File_tail; fp != last; fp = fp->prev) if (fp->percent == NO_PROB) { fp->percent = frac; percent -= frac; Now ``murphy'' and ``startrek'' are treated equally. >Release-Note: >Audit-Trail: >Unformatted: