Date: Mon, 25 Aug 2014 15:52:51 +0200 From: John Marino <freebsd.contact@marino.st> To: Adam Weinberger <adamw@adamw.org>, Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r365735 - in head/games: . prboom-plus Message-ID: <53FB3FB3.90508@marino.st> In-Reply-To: <F714F3E9-01A2-4D60-99D3-7EA6136CFF75@adamw.org> References: <201408231404.s7NE4Ds7036892@svn.freebsd.org> <20140825093243.GC66191@FreeBSD.org> <F714F3E9-01A2-4D60-99D3-7EA6136CFF75@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/25/2014 15:43, Adam Weinberger wrote: > On 25 Aug, 2014, at 5:32, Alexey Dokuchaev <danfe@FreeBSD.org> > wrote: >> COMMENT line is wrong. :) > > Because it starts with an article? I’d posit that that article > improves readability of this particular COMMENT. Yes, because it starts with an article. We've been instructed to remove them unconditionally. Hundreds of ports have comments equivalent to "Fork of the doom game engine prboom", so it's not special in any way. Unfortunately portlint doesn't check for this. I'd add this to the current catch-all portlint rule PR. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53FB3FB3.90508>