Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Nov 2006 23:01:37 GMT
From:      Olivier Houchard <cognet@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 109570 for review
Message-ID:  <200611082301.kA8N1bNG097305@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=109570

Change 109570 by cognet@cognet on 2006/11/08 23:01:25

	Spell reg "reg", not "val", or funny things happen and the GPIO gets
	really upset :-)
	
	Pointy hat to:	kevlo

Affected files ...

.. //depot/projects/arm/src/sys/arm/xscale/ixp425/ixp425_iic.c#2 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/xscale/ixp425/ixp425_iic.c#2 (text+ko) ====

@@ -149,11 +149,11 @@
 	reg = GPIO_CONF_READ_4(sc, IXP425_GPIO_GPOER);
 
 	if (val)
-		val |= GPIO_I2C_SDA_BIT;
+		reg |= GPIO_I2C_SDA_BIT;
 	else
-		val &= ~GPIO_I2C_SDA_BIT;
+		reg &= ~GPIO_I2C_SDA_BIT;
 
-	GPIO_CONF_WRITE_4(sc, IXP425_GPIO_GPOER, val);
+	GPIO_CONF_WRITE_4(sc, IXP425_GPIO_GPOER, reg);
 	DELAY(I2C_DELAY);
 }
 
@@ -170,11 +170,11 @@
 	reg = GPIO_CONF_READ_4(sc, IXP425_GPIO_GPOER);
 
 	if (val)
-		val |= GPIO_I2C_SCL_BIT;
+		reg |= GPIO_I2C_SCL_BIT;
 	else
-		val &= ~GPIO_I2C_SCL_BIT;
+		reg &= ~GPIO_I2C_SCL_BIT;
 
-	GPIO_CONF_WRITE_4(sc, IXP425_GPIO_GPOER, val);
+	GPIO_CONF_WRITE_4(sc, IXP425_GPIO_GPOER, reg);
 	DELAY(I2C_DELAY);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611082301.kA8N1bNG097305>