From owner-svn-src-head@freebsd.org Sat Feb 16 07:03:33 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B5E714D7AC9 for ; Sat, 16 Feb 2019 07:03:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 89610762DC for ; Sat, 16 Feb 2019 07:03:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x729.google.com with SMTP id w204so7169855qka.2 for ; Fri, 15 Feb 2019 23:03:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NK2fI0iU3AjVbulw/9/9JKAubEAv/s1G0y5YfD84LM4=; b=O78xycvq7d01QAERBnnmL5+FVmNny0Ed8nXrd0NddVx2v0CVdwAp/2VHf8r686ZUpQ k1u6DQuy3Gy68EMrSP+44kO70lWnhCYRbmJ8utuDINhEHQDW29kcuSaAyg03VdozUS6L 4vui67REx5w0QAu2fZJmUSG7KA1uzBKpO403mz+oPf1tMQqCFy1EnkCwh25NRhBCTNHt dtCjB5eD8ST2KQBNLqCDw1n00x5V84PxgffOwKyuU6iZmbFbonaBqZZyRYHZCG+WptQQ WBXofEDrIQE2mf1qBD2elk39jMtnuAEjQNerVJqdeIexLsOsf9i7aFFNwQk/ySDR9uYo BmXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NK2fI0iU3AjVbulw/9/9JKAubEAv/s1G0y5YfD84LM4=; b=jlxXqOra7WuJa1Hd8ttLTaFHC0OJbrY+6eTgKVY547tRQaZ0w8Bf//Km6Zv/5u0EBu E3fYQoKXZje+KG55y/nHpSpyTuQ5VyoCIrtMlz47M8Ng8VLmSraGoQuV1ZBxAdy5hpS4 jxZExNTwUXRX9N8X0u4SqqXfR0kguwtpUqUrrZA42D2qsK3jHiv3sDWbr+97iQOPPJ1N 5lKGhqdBzQYHtkdifD+2fZi5G03yqMCGhikK8r1IBFQCrAve+sfdsbt6nMOSKd9VnPyj DAb+MZTaYdBun7USLZ5pEvZvH3FQpCoGTO7T8/uCQl3+JYMoeX+c9M41pTK4fK5UYkUc QjPA== X-Gm-Message-State: AHQUAubRiCskEHFab+zOnPm5K/eZ/aVcD9tub9R9sWWI7DyoIxW2bu5F B5EKCtQDbAvjmHwyP42IKgJefJL85kY2gnFvqFYXWA== X-Google-Smtp-Source: AHgI3IY4X+kOoASCqgHKjeigqS6y0ZVCSY9Xb9TjUDWVYumBRIHWeO/xX5PzP7N5Z+WzUGmgoicq1Ro3cSHE2E6+Mcw= X-Received: by 2002:a37:6c05:: with SMTP id h5mr9907427qkc.175.1550300610741; Fri, 15 Feb 2019 23:03:30 -0800 (PST) MIME-Version: 1.0 References: <201902160015.x1G0F3EJ060777@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Sat, 16 Feb 2019 00:03:18 -0700 Message-ID: Subject: Re: svn commit: r344191 - head/sbin/nvmecontrol To: Garrett Cooper Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 89610762DC X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=O78xycvq X-Spamd-Result: default: False [-5.25 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[9.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.68)[-0.684,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-2.55)[ip: (-8.11), ipnet: 2607:f8b0::/32(-2.59), asn: 15169(-1.99), country: US(-0.07)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Feb 2019 07:03:33 -0000 On Fri, Feb 15, 2019, 11:42 PM Enji Cooper > On Feb 15, 2019, at 10:25 PM, Warner Losh wrote: > > On Fri, Feb 15, 2019, 9:55 PM Enji Cooper >> >> > On Feb 15, 2019, at 16:15, Warner Losh wrote: >> > >> > Author: imp >> > Date: Sat Feb 16 00:15:02 2019 >> > New Revision: 344191 >> > URL: https://svnweb.freebsd.org/changeset/base/344191 >> > >> > Log: >> > Remove write-only s_flag. >> > >> > Modified: >> > head/sbin/nvmecontrol/firmware.c >> > >> > Modified: head/sbin/nvmecontrol/firmware.c >> > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> > --- head/sbin/nvmecontrol/firmware.c Fri Feb 15 23:46:34 2019 >> (r344190) >> > +++ head/sbin/nvmecontrol/firmware.c Sat Feb 16 00:15:02 2019 >> (r344191) >> > @@ -177,7 +177,7 @@ static void >> > firmware(const struct nvme_function *nf, int argc, char *argv[]) >> > { >> > int fd =3D -1, slot =3D 0; >> > - int a_flag, s_flag, f_flag; >> > + int a_flag, f_flag; >> > int activate_action, reboot_required; >> > int opt; >> > char *p, *image =3D NULL; >> > @@ -188,7 +188,7 @@ firmware(const struct nvme_function *nf, int argc, >> cha >> > uint8_t fw_slot1_ro, fw_num_slots; >> > struct nvme_controller_data cdata; >> > >> > - a_flag =3D s_flag =3D f_flag =3D false; >> > + a_flag =3D f_flag =3D false; >> > >> > while ((opt =3D getopt(argc, argv, "af:s:")) !=3D -1) { >> >> Hi Warner! >> Should =E2=80=9Cs:=E2=80=9D be removed here, along with any correspo= nding >> documentation about =E2=80=98-s foo=E2=80=99? >> > > The docs are poo. s: should not be removed, since it is the slot and > required. The code set slot and s_flag. The latter is bogus, so I removed > it. > > > 0-o.. I see. Ok, carry on! > I have other improvements that are real in the pipe, including plans to fix the docs. Just slogging through the details right now when I have time... But since I noticed this and it was independent and a no brainer, I did this first. Warner