From owner-freebsd-stable@FreeBSD.ORG Sat Mar 4 01:47:59 2006 Return-Path: X-Original-To: stable@freebsd.org Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70D7316A420 for ; Sat, 4 Mar 2006 01:47:59 +0000 (GMT) (envelope-from bkelly@vadev.org) Received: from mail4.sea5.speakeasy.net (mail4.sea5.speakeasy.net [69.17.117.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFCE243D46 for ; Sat, 4 Mar 2006 01:47:58 +0000 (GMT) (envelope-from bkelly@vadev.org) Received: (qmail 11577 invoked from network); 4 Mar 2006 01:47:58 -0000 Received: from vadev.org (HELO [192.168.1.97]) (Desdicardo@[66.92.166.151]) (envelope-sender ) by mail4.sea5.speakeasy.net (qmail-ldap-1.03) with RC4-MD5 encrypted SMTP for ; 4 Mar 2006 01:47:57 -0000 From: Ben Kelly To: stable@freebsd.org, wkoszek@freebsd.org Date: Fri, 3 Mar 2006 20:47:54 -0500 User-Agent: KMail/1.8.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200603032047.54811.bkelly@vadev.org> Cc: Subject: missing dependency - crypto.ko to zlib.ko X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2006 01:47:59 -0000 Hello all, I upgraded my RELENG_6 server today and ran into a strange problem. Whenever I try to kldload crypto.ko the operation fails and I get the following error in my dmesg: link_elf: symbol inflateInit2_ undefined I was indirectly trying to load crypto because I had geom_eli.ko in my loader.conf. I don't have any crypto hardware in the box. I'm guessing this is related to this commit: http://lists.freebsd.org/pipermail/cvs-src/2006-March/060511.html It appears that the MODULE_DEPEND macro was added to cryptodev.c, but not to crypto.c. I tried adding MODULE_DEPEND to crypto.c and the problem went away. I'm not that familiar with the module system, so perhaps there is something else wrong with my configuration and this is the wrong fix. In any case, here is the patch: --- crypto.c.orig Fri Mar 3 20:21:35 2006 +++ crypto.c Fri Mar 3 20:21:04 2006 @@ -252,6 +252,7 @@ }; MODULE_VERSION(crypto, 1); DECLARE_MODULE(crypto, crypto_mod, SI_SUB_DRIVERS, SI_ORDER_FIRST); +MODULE_DEPEND(crypto, zlib, 1, 1, 1); /* * Create a new session. For reference, I am running: FreeBSD vir.in.vadev.org 6.1-PRERELEASE FreeBSD 6.1-PRERELEASE #0: Fri Mar 3 16:23:47 EST 2006 bkelly@vir.in.vadev.org:/usr/obj/usr/src/sys/SERVER i386 Last cvsup'd at 2006-03-03 04:07:00 EST. Please let me know if there is a better way to fix this. Any input would be appreciated. Thanks. - Ben