From owner-freebsd-ports Thu Jun 6 9:20: 9 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 3EF1D37B404 for ; Thu, 6 Jun 2002 09:20:02 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g56GK2a75993; Thu, 6 Jun 2002 09:20:02 -0700 (PDT) (envelope-from gnats) Received: from nwww.freebsd.org (www.FreeBSD.org [216.136.204.117]) by hub.freebsd.org (Postfix) with ESMTP id 8DEB637B401 for ; Thu, 6 Jun 2002 09:17:13 -0700 (PDT) Received: from www.freebsd.org (localhost [127.0.0.1]) by nwww.freebsd.org (8.12.2/8.12.2) with ESMTP id g56GHDhG089434 for ; Thu, 6 Jun 2002 09:17:13 -0700 (PDT) (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.2/8.12.2/Submit) id g56GHDrx089433; Thu, 6 Jun 2002 09:17:13 -0700 (PDT) Message-Id: <200206061617.g56GHDrx089433@www.freebsd.org> Date: Thu, 6 Jun 2002 09:17:13 -0700 (PDT) From: David Marshall To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-1.0 Subject: ports/38950: perforce Makefile doesn't do PORTREVISION correctly plus p4d update Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 38950 >Category: ports >Synopsis: perforce Makefile doesn't do PORTREVISION correctly plus p4d update >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Jun 06 09:20:01 PDT 2002 >Closed-Date: >Last-Modified: >Originator: David Marshall >Release: 4.5-RELEASE-p4 >Organization: >Environment: FreeBSD server1.chezmarshall.com 4.5-RELEASE-p4 FreeBSD 4.5-RELEASE-p4 #0: Tue Apr 23 12:45:43 EDT 2002 marshall@server1.chezmarshall.com:/disk3/obj/disk2/src/sys/CHEZMARSHALL i386 >Description: A mechanism to separate PORTVERSION and PORTREVISION for i386 and alpha was implemented some time ago, but it doesn't work properly when forming the package name. Regardless of what VERSION is in the i386 block, the package name will always be perforce-02.1,1 rather than (for instance) perforce-02.1_3,1. Probably has something to do with package name being formed from macro _SUF1 rather than directly from PORTREVISION. I suck at make. >How-To-Repeat: Fiddle with VERSION and see that the package name doesn't change. >Fix: This is such an embarrassing kludge, but I don't have enough familiarity with the ports makefiles to come up with anything better. Just set _SUF to what we want it to be... Patch to current ports/devel/perforce can be grabbed from http://www.chezmarshall.com/perforce.diff.txt. >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message