From owner-freebsd-ports@FreeBSD.ORG Thu Mar 6 00:05:10 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C224433C for ; Thu, 6 Mar 2014 00:05:10 +0000 (UTC) Received: from mailhost.m5p.com (ip-2-1-0-2.r03.asbnva02.us.ce.gin.ntt.net [IPv6:2001:418:0:5000::16]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 614E2FBD for ; Thu, 6 Mar 2014 00:05:10 +0000 (UTC) Received: from wonderland.m5p.com (localhost [IPv6:::1]) by mailhost.m5p.com (8.14.5/8.14.5) with ESMTP id s26051Sw057331; Wed, 5 Mar 2014 19:05:06 -0500 (EST) (envelope-from george+freebsd@m5p.com) Message-ID: <5317BBAD.9070107@m5p.com> Date: Wed, 05 Mar 2014 19:05:01 -0500 From: George Mitchell User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Ren=E9_Ladan?= Subject: Re: Adventures in ports, chapter 346785 References: <5315B8FF.5020907@m5p.com> <531673AB.7000807@m5p.com> <5316E0A1.2020406@gmail.com> <53170768.1060504@m5p.com> <53170F8B.8080303@gmail.com> In-Reply-To: <53170F8B.8080303@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.73 on 10.100.0.3 X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7 (mailhost.m5p.com [IPv6:::1]); Wed, 05 Mar 2014 19:05:08 -0500 (EST) Cc: freebsd ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Mar 2014 00:05:10 -0000 On 03/05/14 06:50, René Ladan wrote: > On 03/05/2014 12:15, George Mitchell wrote: >> On 03/05/14 03:30, René Ladan wrote: >>> On 03/05/2014 01:45, George Mitchell wrote: >>>> On 03/04/14 13:28, René Ladan wrote: >>>>> 2014-03-04 12:29 GMT+01:00 George Mitchell >>>> >: >>>>> >>>>> Couldn't compile chromium without attached patch on FreeBSD 8.4. >>>>> >>>>> >>>>> I committed a slightly different version of your patch in r347055, can >>>>> you retry? >>>>> >>>>> René >>>>> >>>> Thanks for your help, but this doesn't seem to fix the compile errors >>>> in content/browser/browser_shutdown_profile_dumper.cc, >>>> testing/perf/perf_test.cc, or ui/gfx/codec/jpeg_codec.cc that were >>>> caused by the absence or misordering of stdio.h. -- George >>>> >>> Hmm, I did add the patch for >>> content/browser/browser_shutdown_profile_dumper.cc as a conditional >>> patch when using GCC (i.e. in files/extra-patch-gcc). >> >> You are right, I didn't get the FILE error in that file. Sorry for >> typing my reply too quickly. >> > No problem. Does it work now? > >>> I indeed forgot to add the other two patches which I added to >>> files/extra-patch-gcc too (having to place stdio.h before .h >>> looks fishy, but that's another story). >>> >>>> From what I see on my virtual 8.4 box, chromium should choose GCC 4.7+ >>> as compiler (and clang on 10.0). >>> >>> To be really sure, what is the output of 'make -V CHOSEN_COMPILER_TYPE' >>> on your box? >>> >>> René >>> >> >> sullivan.m5p.com.1) uname -a >> FreeBSD sullivan.m5p.com 8.4-STABLE FreeBSD 8.4-STABLE #0 r254883: Sun >> Aug 25 15:52:19 EDT 2013 >> george@sullivan.m5p.com:/usr/obj/usr/src/sys/M5P amd64 >> sullivan.m5p.com.2) make -V CHOSEN_COMPILER_TYPE >> > Uhm, nothing ... I should have said to run this in > /usr/ports/www/chromium ... [...] In /usr/ports/www/chromium, it says "gcc". I have gcc46 and gcc47 installed from ports. -- George