Date: Wed, 9 Oct 2013 13:12:15 GMT From: "George L. Yermulnik" <yz@yz.kiev.ua> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/182853: ports/textproc/urlview: regex -> pcreregex Message-ID: <201310091312.r99DCFGk085371@oldred.freebsd.org> Resent-Message-ID: <201310091320.r99DK0Do035423@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 182853 >Category: ports >Synopsis: ports/textproc/urlview: regex -> pcreregex >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Oct 09 13:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: George L. Yermulnik >Release: 8.3-STABLE >Organization: >Environment: FreeBSD yz.iptelecom.net.ua 8.3-STABLE FreeBSD 8.3-STABLE #10: Thu May 3 19:49:11 EEST 2012 root@yz.iptelecom.net.ua:/usr/obj/usr/src/sys/YZ i386 >Description: I've managed to make ports/textproc/urlview work not just with extended regular expressions, but with PCRE. Please, take a look at attached port directory patch (it adds CFLAGS/LDFLAGS to Makefile and a string to files/patch-urlview.c). If patch is Ok, please, commit this changes. Thanx in advance. >How-To-Repeat: >Fix: See the patch attached. Patch attached with submission follows: diff -ru urlview.orig/Makefile urlview/Makefile --- urlview.orig/Makefile 2013-10-09 14:26:51.000000000 +0300 +++ urlview/Makefile 2013-10-09 14:38:01.000000000 +0300 @@ -20,6 +20,9 @@ PLIST_FILES= bin/urlview \ etc/urlview.conf.sample +CFLAGS+= -I${LOCALBASE}/include +LDFLAGS+= -L${LOCALBASE}/lib -lpcreposix -lpcre + NO_STAGE= yes post-patch: @${REINPLACE_CMD} -e 's,/etc,${PREFIX}&,' \ diff -ru urlview.orig/files/patch-urlview.c urlview/files/patch-urlview.c --- urlview.orig/files/patch-urlview.c 2013-10-09 14:26:51.000000000 +0300 +++ urlview/files/patch-urlview.c 2013-10-09 14:31:35.000000000 +0300 @@ -1,11 +1,17 @@ ---- urlview.c.orig Wed Nov 9 15:34:39 2005 -+++ urlview.c Wed Nov 9 15:35:06 2005 -@@ -46,6 +46,8 @@ +--- urlview.c.orig 2013-10-09 14:30:43.000000000 +0300 ++++ urlview.c 2013-10-09 14:30:43.000000000 +0300 +@@ -41,11 +41,13 @@ + #include <sys/stat.h> + + #ifdef HAVE_REGEX_H +-#include <regex.h> ++#include <pcreposix.h> + #else #include <rx/rxposix.h> #endif +#include "quote.h" + #define DEFAULT_REGEXP "(((https?|ftp|gopher)://|(mailto|file|news):)[^' \t<>\"]+|(www|web|w3)\\.[-a-z0-9.]+)[^' \t.,;<>\"\\):]" - #define DEFAULT_COMMAND "url_handler.sh %s" + #define DEFAULT_COMMAND "firefox %s" #define SYSTEM_INITFILE "/usr/local/etc/urlview.conf" >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310091312.r99DCFGk085371>