From owner-freebsd-ports@FreeBSD.ORG Mon May 31 18:36:01 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8CE716A4CE for ; Mon, 31 May 2004 18:36:01 -0700 (PDT) Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9344643D1F for ; Mon, 31 May 2004 18:36:01 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (10509f97134a1f3b8d574883690a4d47@adsl-67-115-73-128.dsl.lsan03.pacbell.net [67.115.73.128]) by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i511ZrCa005696 for ; Mon, 31 May 2004 18:35:53 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 6A0FD521D5; Mon, 31 May 2004 18:35:52 -0700 (PDT) Date: Mon, 31 May 2004 18:35:52 -0700 From: Kris Kennaway To: freebsd-ports Message-ID: <20040601013552.GA23068@xor.obsecurity.org> References: <20040531233106.GE85902@isis.wad.cz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: <20040531233106.GE85902@isis.wad.cz> User-Agent: Mutt/1.4.2.1i Subject: Re: respect CFLAGS: should I override optimizations? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2004 01:36:01 -0000 --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 01, 2004 at 01:31:06AM +0200, Roman Neuhauser wrote: > I'm updating biology/migrate, the upstream Makefile.in includes >=20 > CFLAGS =3D @CFLAGS@ ... >=20 > and configure says: >=20 > case "$GCC" in > yes) CFLAGS=3D"-O3 -Wall -ffast-math -funroll-loops -fomit-frame-pointer= -fexpensive-optimizations -D$CPUTYPE" ;; > =20 > If I was to take Porter's Hang^Hdbook literally, I would change the > set (=3D) to append (+=3D) and be done with it, but is that really what > I'm expected to do? That's not the intent..usually the port should be built with *only* the optimizations specified in CFLAGS/CXXFLAGS, not CFLAGS overridden by the software defaults. Perhaps the porter's handbook is unclear. If you want to leave the software optimizations as an option, you could put them under WITH_OPTIMIZED_CFLAGS, which seems to have become a de facto standard. Kris --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAu914Wry0BWjoQKURAt94AJwJ62eKBwSW/caHtgnMbZbkm569BACdGRUe dwFRlQpMCkIX3ObZVz7hRnc= =hv94 -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--