From owner-freebsd-hackers@FreeBSD.ORG  Wed Jan 30 23:09:32 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E3E4616A420
	for <freebsd-hackers@freebsd.org>; Wed, 30 Jan 2008 23:09:32 +0000 (UTC)
	(envelope-from gahr@gahr.ch)
Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73])
	by mx1.freebsd.org (Postfix) with ESMTP id A783413C4EB
	for <freebsd-hackers@freebsd.org>; Wed, 30 Jan 2008 23:09:32 +0000 (UTC)
	(envelope-from gahr@gahr.ch)
Received: from 80-218-191-236.dclient.hispeed.ch ([80.218.191.236]
	helo=gahrtop.localhost)
	by cpanel03.rubas-s03.net with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.68) (envelope-from <gahr@gahr.ch>) id 1JKM3e-0006ku-LV
	for freebsd-hackers@freebsd.org; Thu, 31 Jan 2008 00:09:30 +0100
Message-ID: <47A103A1.4030108@gahr.ch>
Date: Thu, 31 Jan 2008 00:09:21 +0100
From: Pietro Cerutti <gahr@gahr.ch>
User-Agent: Thunderbird 2.0.0.9 (X11/20071121)
MIME-Version: 1.0
To: freebsd-hackers@freebsd.org
X-Enigmail-Version: 0.95.5
OpenPGP: id=9571F78E;
	url=http://www.gahr.ch/pgp
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature";
	boundary="------------enig307DB583FA6C84EDAE64775F"
X-AntiAbuse: This header was added to track abuse,
	please include it with any abuse report
X-AntiAbuse: Primary Hostname - cpanel03.rubas-s03.net
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - gahr.ch
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Subject: more on devstat (missing include)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jan 2008 23:09:33 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig307DB583FA6C84EDAE64775F
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi hackers,

I think that i) sys/devicestat.h should include sys/resource.h or ii)
the man page of devstat(9) should mention that the user himself is
supposed to include sys/resource.h.

Without:

> cat devstat.c
#include <devstat.h>

int main(void)
{
   devstat_getnumdevs(NULL);
   return (0);
}
> gcc -ldevstat -o devstat devstat.c
In file included from devstat.c:1:
/usr/include/devstat.h:131: error: 'CPUSTATES' undeclared here (not in a
function)
Exit 1


I can provide a patch if someone could tell me which one of the proposed
solutions above is the preferred one.

Thanks,

--=20
Pietro Cerutti

PGP Public Key:
http://gahr.ch/pgp


--------------enig307DB583FA6C84EDAE64775F
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)

iD8DBQFHoQOlwMJqmJVx944RCgjJAJoCm8Wbt9wb73OIsCHmvw0K6p+G4gCg5RGe
tUIcVTVUMh/hyYxXsuTT+a4=
=jG/6
-----END PGP SIGNATURE-----

--------------enig307DB583FA6C84EDAE64775F--