Date: Wed, 29 Aug 2018 13:59:31 -0400 From: Dan Langille <dan@langille.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: Yuri Pankov <yuripv@yuripv.net>, FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: Bacula 9.2.1 fails on 10.4: Message-ID: <5B4F0FB9-0F97-42BF-9692-698F7ED4AE11@langille.org> In-Reply-To: <CAJE75NEU446M4R5sWTiLyhbmZZk%2B9TnTZpoFdwvq3FSCWwpKmQ@mail.gmail.com> References: <320B7D85-8E73-4214-8343-DDA3F448E473@langille.org> <4e03e6b7-f866-f6f8-bab1-285fbe36a0f9@yuripv.net> <23601736-1846-4B86-AAC2-1A0871852C21@langille.org> <CAJE75NEU446M4R5sWTiLyhbmZZk%2B9TnTZpoFdwvq3FSCWwpKmQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Aug 29, 2018, at 10:59 AM, Jason E. Hale <jhale@freebsd.org> wrote: >=20 > On Mon, Aug 27, 2018 at 7:42 PM Dan Langille <dan@langille.org> wrote: >>=20 >>> On Aug 27, 2018, at 7:26 PM, Yuri Pankov <yuripv@yuripv.net> wrote: >>>=20 >>> Dan Langille wrote: >>>> Why would Bacula 9.2.1 compile on 11.2 but fail on 10.4? >>>> The error is: >>>> bsock.c:439:20: error: use of undeclared identifier 'ENODATA' >>>> The complete build logs are at the following URLs. Can you see the = cause. >>>> 11.2: = https://services.unixathome.org/poudriere/data/112amd64-default/2018-08-27= _21h15m53s/logs/bacula9-client-9.2.1.log >>>> 10.4: = https://services.unixathome.org/poudriere/data/104amd64-default/2018-08-27= _21h43m31s/logs/errors/bacula9-client-9.2.1.log >>>> It doesn't make any sense to me. Thanks. >>>=20 >>> I'd say it's libc++ missing its errno.h having ENODATA defined if = the following is true: >>>=20 >>> - both builds are using clang++ >>> - both builds are using libc++ >>>=20 >>> That header defining ENODATA exists in 11.2 and doesn't exist in = 10.4 (contrib/libc++/include/errno.h). >>=20 >> What is a decent solution? Patch upstream? Patch the port? >>=20 >> Thank you. >>=20 >=20 > You can patch the port for now and submit it upstream. I think they have patched upstream already, just not released it: = http://www.bacula.org/git/cgit.cgi/bacula/commit/?h=3DBranch-9.2&id=3Deea8= 17f035d32221ab46d1a4f95193cd4d6dbda7 > Looks like they > had ENODATA defined as EPIPE and missed it when they refactored: > = http://www.bacula.org/git/cgit.cgi/bacula/commit/bacula/src/lib/bsock.c?h=3D= Release-9.2.1&id=3Dc3c124adbe784a55bb31c66401630b2d22768baf. > Now that code is in: > = http://www.bacula.org/git/cgit.cgi/bacula/tree/bacula/src/lib/bsockcore.c?= h=3DRelease-9.2.1#n44, > but it needs to be in both files. > I think it would make more sense to factor it out to src/baconfig.h. > That way, they could remove the #if block from bsockcore.c. I've > attached a patch and put it in plain text below in case it gets > scrubbed. Thank you Jason, this is very helpful. I will pass this upsteam, and in = the meantime, fix the port. cheers. >=20 > Cheers, > Jason >=20 > Index: sysutils/bacula9-server/files/patch-src_baconfig.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sysutils/bacula9-server/files/patch-src_baconfig.h (nonexistent) > +++ sysutils/bacula9-server/files/patch-src_baconfig.h (working copy) > @@ -0,0 +1,13 @@ > +--- src/baconfig.h.orig 2018-08-29 14:09:36 UTC > ++++ src/baconfig.h > +@@ -38,6 +38,10 @@ > + #define have_tls 0 > + #endif > + > ++#ifndef ENODATA > ++#define ENODATA EPIPE > ++#endif > ++ > + #ifndef ETIME > + #define ETIME ETIMEDOUT > + #endif >=20 > Property changes on: = sysutils/bacula9-server/files/patch-src_baconfig.h > ___________________________________________________________________ > Added: fbsd:nokeywords > ## -0,0 +1 ## > +yes > \ No newline at end of property > Added: svn:eol-style > ## -0,0 +1 ## > +native > \ No newline at end of property > Added: svn:mime-type > ## -0,0 +1 ## > +text/plain > \ No newline at end of property > <bacula9-server.diff> --=20 Dan Langille - BSDCan / PGCon dan@langille.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5B4F0FB9-0F97-42BF-9692-698F7ED4AE11>