Date: Sun, 16 Dec 2001 18:17:27 -0800 From: Kent Stewart <kstewart@owt.com> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, =?ISO-8859-1?Q?S=F8ren?= Schmidt <sos@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/ata ata-dma.c ata-pci.c Message-ID: <3C1D55B7.5020007@owt.com> References: <XFMail.011216160444.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > On 16-Dec-01 Kent Stewart wrote: > >> >>Søren Schmidt wrote: >> >> > sos 2001/12/14 13:28:50 PST >> > >> > Modified files: >> > sys/dev/ata ata-dma.c ata-pci.c >> > Log: >> > Adjust the timings for the SiS chips a bit, also add the SiS 645. >> > >> > Cosmetics on the Acer chips (print right modes) >> > >> > Revision Changes Path >> > 1.78 +9 -8 src/sys/dev/ata/ata-dma.c >> > 1.22 +8 -5 src/sys/dev/ata/ata-pci.c >> > >> >> >>Your change has a cosmetic error in the line in ata-dma.c. You have >> >> ata_find_dev(parent, 0x06451039, 0x00) || /* SiS 635 */ >> >>but the comment should be for a 745. The 745 chipset line is missing in >>the ata-pci.c module. >> > > Eh? I submitted that cause I was testing on a SiS 645 chipset. :) Perhaps you > need to add the 745 as well then in an additional line. There is definitely a > 645 chipset though, it is for Pentium 4 systems. I really meant 645 and figured it was a dumb enough mistake that everyone would have seen what I meant. I was also aware of the 745 chipset boards being advertised on the ECS web site as a K7S6A. I assigned it as one of my braino's for the day and quit. Kent > > -- Kent Stewart Richland, WA mailto:kbstew99@hotmail.com http://users.owt.com/kstewart/index.html FreeBSD News http://daily.daemonnews.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C1D55B7.5020007>